Commit 0fe0781f authored Apr 20, 2020 by Paulo Alcantara Committed by Steve French Apr 22, 2020

cifs: fix uninitialised lease_key in open_shroot()



SMB2_open_init() expects a pre-initialised lease_key when opening a
file with a lease, so set pfid->lease_key prior to calling it in
open_shroot().

This issue was observed when performing some DFS failover tests and
the lease key was never randomly generated.

Signed-off-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
Signed-off-by: Steve French <stfrench@microsoft.com>
Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
CC: Stable <stable@vger.kernel.org>

parent 3786f4bd

fs/cifs/smb2ops.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -687,6 +687,11 @@ int open_shroot(unsigned int xid, struct cifs_tcon *tcon,
		if (smb3_encryption_required(tcon))
		flags \|= CIFS_TRANSFORM_REQ;

		if (!server->ops->new_lease_key)
		return -EIO;

		server->ops->new_lease_key(pfid);

		memset(rqst, 0, sizeof(rqst));
		resp_buftype[0] = resp_buftype[1] = CIFS_NO_BUFFER;
		memset(rsp_iov, 0, sizeof(rsp_iov));

Admin message