Commit 0fd64291 authored Aug 01, 2015 by Nicolas Iooss Committed by Alex Deucher Aug 05, 2015

drm/amdgpu: increment queue when iterating on this variable.



gfx_v7_0_print_status contains a for loop on variable queue which does
not update this variable between each iteration.  This is bug is
reported by clang while building allmodconfig LLVMLinux on x86_64:

    drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:5126:19: error: variable
    'queue' used in loop condition not modified in loop body
    [-Werror,-Wloop-analysis]
                for (queue = 0; queue < 8; i++) {
                                ^~~~~

Fix this by incrementing variable queue instead of i in this loop.

Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

parent a0e2f50b

drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -5122,7 +5122,7 @@ static void gfx_v7_0_print_status(void *handle)
		dev_info(adev->dev, " CP_HPD_EOP_CONTROL=0x%08X\n",
		RREG32(mmCP_HPD_EOP_CONTROL));

		for (queue = 0; queue < 8; i++) {
		for (queue = 0; queue < 8; queue++) {
		cik_srbm_select(adev, me, pipe, queue, 0);
		dev_info(adev->dev, " queue: %d\n", queue);
		dev_info(adev->dev, " CP_PQ_WPTR_POLL_CNTL=0x%08X\n",

Admin message