mmc: sdhci: Report failure reasons for all cases in sdhci_add_host() (0fc81ee3) · Commits · 戴 / test

For most error conditions sdhci_add_host() will print a diagnostic message indicating why it failed but there are a few cases where this does not happen. Add error messages in these cases to aid diagnosis. Signed-off-by:

Mark Brown <broonie@opensource.wolfsonmicro.com> Signed-off-by:

Chris Ball <cjb@laptop.org>

drivers/mmc/host/sdhci.c

+8 −2

Original line number	Diff line number	Diff line
		@@ -3033,8 +3033,11 @@ int sdhci_add_host(struct sdhci_host *host)

		ret = request_irq(host->irq, sdhci_irq, IRQF_SHARED,
		mmc_hostname(mmc), host);
		if (ret)
		if (ret) {
		pr_err("%s: Failed to request IRQ %d: %d\n",
		mmc_hostname(mmc), host->irq, ret);
		goto untasklet;
		}

		sdhci_init(host, 0);

		@@ -3051,8 +3054,11 @@ int sdhci_add_host(struct sdhci_host *host)
		host->led.brightness_set = sdhci_led_control;

		ret = led_classdev_register(mmc_dev(mmc), &host->led);
		if (ret)
		if (ret) {
		pr_err("%s: Failed to register LED device: %d\n",
		mmc_hostname(mmc), ret);
		goto reset;
		}
		#endif

		mmiowb();

Admin message