sh: unwinder: Convert frame allocations to GFP_ATOMIC. (0fc11e36) · Commits · 戴 / test

save_stack_trace_tsk() and friends can be called from atomic context (as triggered by latencytop), and subsequently hit two problematic allocation points that were using GFP_KERNEL (these were dwarf_unwind_stack() and dwarf_frame_alloc_regs()). Convert these over to GFP_ATOMIC and get latencytop working with the DWARF unwinder. Signed-off-by:

Paul Mundt <lethal@linux-sh.org>

arch/sh/kernel/dwarf.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -57,7 +57,7 @@ static void dwarf_frame_alloc_regs(struct dwarf_frame *frame,
		if (frame->num_regs >= num_regs)
		return;

		regs = kzalloc(new_size, GFP_KERNEL);
		regs = kzalloc(new_size, GFP_ATOMIC);
		if (!regs) {
		printk(KERN_WARNING "Unable to allocate DWARF registers\n");
		/*
		@@ -531,7 +531,7 @@ struct dwarf_frame *dwarf_unwind_stack(unsigned long pc,
		define_ra = true;
		}

		frame = kzalloc(sizeof(*frame), GFP_KERNEL);
		frame = kzalloc(sizeof(*frame), GFP_ATOMIC);
		if (!frame)
		return NULL;

Admin message