Commit 0fa83cdb authored Aug 24, 2012 by Josef Bacik Committed by Chris Mason Oct 01, 2012

Btrfs: only warn if we hit an error when doing the tree logging

I hit this a couple times while working on my fsync patch (all my bugs, not
normal operation), but with my new stuff we could have new errors from cases
I have not encountered, so instead of BUG()'ing we should be WARN()'ing so
that we are notified there is a problem but the user doesn't lose their
data. We can easily commit the transaction in the case that the tree
logging fails and still be fine, so let's try and be as nice to the user as
possible. Thanks,

Signed-off-by: Josef Bacik <jbacik@fusionio.com>

parent 5dc562c5

fs/btrfs/tree-log.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3346,7 +3346,7 @@ int btrfs_log_inode_parent(struct btrfs_trans_handle *trans,
		end_trans:
		dput(old_parent);
		if (ret < 0) {
		BUG_ON(ret != -ENOSPC);
		WARN_ON(ret != -ENOSPC);
		root->fs_info->last_trans_log_full_commit = trans->transid;
		ret = 1;
		}

Admin message