Commit 0f930902 authored Nov 06, 2015 by Greg Thelen Committed by Linus Torvalds Nov 06, 2015

fs, seqfile: always allow oom killer



Since 5cec38ac ("fs, seq_file: fallback to vmalloc instead of oom kill
processes") seq_buf_alloc() avoids calling the oom killer for PAGE_SIZE or
smaller allocations; but larger allocations can use the oom killer via
vmalloc().  Thus reads of small files can return ENOMEM, but larger files
use the oom killer to avoid ENOMEM.

The effect of this bug is that reads from /proc and other virtual
filesystems can return ENOMEM instead of the preferred behavior - oom
killing something (possibly the calling process).  I don't know of anyone
except Google who has noticed the issue.

I suspect the fix is more needed in smaller systems where there isn't any
reclaimable memory.  But these seem like the kinds of systems which
probably don't use the oom killer for production situations.

Memory overcommit requires use of the oom killer to select a victim
regardless of file size.

Enable oom killer for small seq_buf_alloc() allocations.

Fixes: 5cec38ac ("fs, seq_file: fallback to vmalloc instead of oom kill processes")
Signed-off-by: David Rientjes <rientjes@google.com>
Signed-off-by: Greg Thelen <gthelen@google.com>
Acked-by: Eric Dumazet <edumazet@google.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 25c6bb76

fs/seq_file.c

+8 −3

Original line number	Diff line number	Diff line
		@@ -26,12 +26,17 @@ static void seq_set_overflow(struct seq_file *m)
		static void *seq_buf_alloc(unsigned long size)
		{
		void *buf;
		gfp_t gfp = GFP_KERNEL;

		/*
		* __GFP_NORETRY to avoid oom-killings with high-order allocations -
		* it's better to fall back to vmalloc() than to kill things.
		* For high order allocations, use __GFP_NORETRY to avoid oom-killing -
		* it's better to fall back to vmalloc() than to kill things. For small
		* allocations, just use GFP_KERNEL which will oom kill, thus no need
		* for vmalloc fallback.
		*/
		buf = kmalloc(size, GFP_KERNEL \| __GFP_NORETRY \| __GFP_NOWARN);
		if (size > PAGE_SIZE)
		gfp \|= __GFP_NORETRY \| __GFP_NOWARN;
		buf = kmalloc(size, gfp);
		if (!buf && size > PAGE_SIZE)
		buf = vmalloc(size);
		return buf;

Admin message