Commit 0f90be13 authored by Bill Baker's avatar Bill Baker Committed by Anna Schumaker
Browse files

NFSv4 client live hangs after live data migration recovery 



After a live data migration event at the NFS server, the client may send
I/O requests to the wrong server, causing a live hang due to repeated
recovery events.  On the wire, this will appear as an I/O request failing
with NFS4ERR_BADSESSION, followed by successful CREATE_SESSION, repeatedly.
NFS4ERR_BADSSESSION is returned because the session ID being used was
issued by the other server and is not valid at the old server.

The failure is caused by async worker threads having cached the transport
(xprt) in the rpc_task structure.  After the migration recovery completes,
the task is redispatched and the task resends the request to the wrong
server based on the old value still present in tk_xprt.

The solution is to recompute the tk_xprt field of the rpc_task structure
so that the request goes to the correct server.

Signed-off-by: default avatarBill Baker <bill.baker@oracle.com>
Reviewed-by: default avatarChuck Lever <chuck.lever@oracle.com>
Tested-by: default avatarHelen Chao <helen.chao@oracle.com>
Fixes: fb43d172 ("SUNRPC: Use the multipath iterator to assign a ...")
Cc: stable@vger.kernel.org # v4.9+
Signed-off-by: default avatarAnna Schumaker <Anna.Schumaker@Netapp.com>
parent 32cd3ee5

fs/nfs/nfs4proc.c

+8 −1
Original line number Diff line number Diff line
@@ -581,8 +581,15 @@ nfs4_async_handle_exception(struct rpc_task *task, struct nfs_server *server, 
		ret = -EIO;

	return ret;

out_retry:

	if (ret == 0)

	if (ret == 0) {

		exception->retry = 1;

		/*

		 * For NFS4ERR_MOVED, the client transport will need to

		 * be recomputed after migration recovery has completed.

		 */

		if (errorcode == -NFS4ERR_MOVED)

			rpc_task_release_transport(task);

	}

	return ret;

}

include/linux/sunrpc/clnt.h

+1 −0
Original line number Diff line number Diff line
@@ -156,6 +156,7 @@ int rpc_switch_client_transport(struct rpc_clnt *, 


void		rpc_shutdown_client(struct rpc_clnt *);

void		rpc_release_client(struct rpc_clnt *);

void		rpc_task_release_transport(struct rpc_task *);

void		rpc_task_release_client(struct rpc_task *);



int		rpcb_create_local(struct net *);

net/sunrpc/clnt.c

+20 −8
Original line number Diff line number Diff line
@@ -965,10 +965,20 @@ out: 
}

EXPORT_SYMBOL_GPL(rpc_bind_new_program);



void rpc_task_release_transport(struct rpc_task *task)

{

	struct rpc_xprt *xprt = task->tk_xprt;



	if (xprt) {

		task->tk_xprt = NULL;

		xprt_put(xprt);

	}

}

EXPORT_SYMBOL_GPL(rpc_task_release_transport);



void rpc_task_release_client(struct rpc_task *task)

{

	struct rpc_clnt *clnt = task->tk_client;

	struct rpc_xprt *xprt = task->tk_xprt;



	if (clnt != NULL) {

		/* Remove from client task list */
@@ -979,12 +989,14 @@ void rpc_task_release_client(struct rpc_task *task) 


		rpc_release_client(clnt);

	}



	if (xprt != NULL) {

		task->tk_xprt = NULL;



		xprt_put(xprt);

	rpc_task_release_transport(task);

}



static

void rpc_task_set_transport(struct rpc_task *task, struct rpc_clnt *clnt)

{

	if (!task->tk_xprt)

		task->tk_xprt = xprt_iter_get_next(&clnt->cl_xpi);

}



static
@@ -992,8 +1004,7 @@ void rpc_task_set_client(struct rpc_task *task, struct rpc_clnt *clnt) 
{



	if (clnt != NULL) {

		if (task->tk_xprt == NULL)

			task->tk_xprt = xprt_iter_get_next(&clnt->cl_xpi);

		rpc_task_set_transport(task, clnt);

		task->tk_client = clnt;

		atomic_inc(&clnt->cl_count);

		if (clnt->cl_softrtry)
@@ -1512,6 +1523,7 @@ call_start(struct rpc_task *task) 
		clnt->cl_program->version[clnt->cl_vers]->counts[idx]++;

	clnt->cl_stats->rpccnt++;

	task->tk_action = call_reserve;

	rpc_task_set_transport(task, clnt);

}



/*

CRA Git | Maintained and supported by SUSTech CRA and CCSE