IB/hfi1: Remove snoop/diag interface (0f7b1f91) · Commits · 戴 / test

The snoop/diag interface is better served by an implementation which is more general and usable by other drivers perhaps. Go ahead and remove the code now and get rid of the char dev. We can put the feature back when we have a more agreeable solution. Reviewed-by:

Dean Luick <dean.luick@intel.com> Reviewed-by:

Mike Marciniszyn <mike.marciniszyn@intel.com> Signed-off-by:

Dennis Dalessandro <dennis.dalessandro@intel.com> Signed-off-by:

Doug Ledford <dledford@redhat.com>

drivers/staging/rdma/hfi1/Makefile

+1 −1

Original line number	Diff line number	Diff line
		@@ -7,7 +7,7 @@
		#
		obj-$(CONFIG_INFINIBAND_HFI1) += hfi1.o

		hfi1-y := affinity.o chip.o device.o diag.o driver.o efivar.o \
		hfi1-y := affinity.o chip.o device.o driver.o efivar.o \
		eprom.o file_ops.o firmware.o \
		init.o intr.o mad.o mmu_rb.o pcie.o pio.o pio_copy.o platform.o \
		qp.o qsfp.o rc.o ruc.o sdma.o sysfs.o trace.o twsi.o \

drivers/staging/rdma/hfi1/diag.c

deleted100644 → 0

+0 −1925

File deleted.

Preview size limit exceeded, changes collapsed.

drivers/staging/rdma/hfi1/file_ops.c

+1 −8

Original line number	Diff line number	Diff line
		@@ -1500,13 +1500,7 @@ static int user_add(struct hfi1_devdata *dd)
		*/
		int hfi1_device_create(struct hfi1_devdata *dd)
		{
		int r, ret;

		r = user_add(dd);
		ret = hfi1_diag_add(dd);
		if (r && !ret)
		ret = r;
		return ret;
		return user_add(dd);
		}

		/*
		@@ -1516,5 +1510,4 @@ int hfi1_device_create(struct hfi1_devdata *dd)
		void hfi1_device_remove(struct hfi1_devdata *dd)
		{
		user_remove(dd);
		hfi1_diag_remove(dd);
		}

Admin message