Commit 0f5da659 authored Oct 25, 2017 by Andrei Vagin Committed by David S. Miller Oct 26, 2017

net/unix: don't show information about sockets from other namespaces



socket_diag shows information only about sockets from a namespace where
a diag socket lives.

But if we request information about one unix socket, the kernel don't
check that its netns is matched with a diag socket namespace, so any
user can get information about any unix socket in a system. This looks
like a bug.

v2: add a Fixes tag

Fixes: 51d7cccf ("net: make sock diag per-namespace")
Signed-off-by: Andrei Vagin <avagin@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 3eb8feeb

net/unix/diag.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -257,6 +257,8 @@ static int unix_diag_get_exact(struct sk_buff *in_skb,
		err = -ENOENT;
		if (sk == NULL)
		goto out_nosk;
		if (!net_eq(sock_net(sk), net))
		goto out;

		err = sock_diag_check_cookie(sk, req->udiag_cookie);
		if (err)

Admin message