Commit 0f46ab46 authored Jun 26, 2020 by Andy Shevchenko Committed by Mauro Carvalho Chehab Jul 18, 2020

media: atomisp: Don't try to parse unexpected ACPI object type



There are devices with completely different _DSM() format,
and accessing object as a package leads to crashes.

Bail out in the case of unexpected object type.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

parent 96310fd8

drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -1134,6 +1134,10 @@ static int gmin_get_config_dsm_var(struct device *dev,
		return -EINVAL;
		}

		/* Return on unexpected object type */
		if (obj->type != ACPI_TYPE_PACKAGE)
		return -EINVAL;

		#if 0 /* Just for debugging purposes */
		for (i = 0; i < obj->package.count; i++) {
		union acpi_object *cur = &obj->package.elements[i];

Admin message