Commit 0f4184f7 authored Aug 23, 2006 by Marc Zyngier Committed by David S. Miller Aug 23, 2006

[SERIAL] sunsab: Fix E250 console with RSC.



This fixes yet another sunsab problem, when console is set to anything
but the first port. The console framework calls sunsab_console_setup
for each port, and we end up setting up a console on a not yet
discovered port, which leads to an Oops. Instead, defer console setup
until the requested port is properly initialized. Tested on an E250
through an RSC console.

Reported by Daniel Smolik <marvin@mydatex.cz>

Signed-off-by: Marc Zyngier <maz@misterjones.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 25848c4e

drivers/serial/sunsab.c

+9 −0

Original line number	Diff line number	Diff line
		@@ -886,6 +886,15 @@ static int sunsab_console_setup(struct console con, char options)
		unsigned long flags;
		unsigned int baud, quot;

		/*
		* The console framework calls us for each and every port
		* registered. Defer the console setup until the requested
		* port has been properly discovered. A bit of a hack,
		* though...
		*/
		if (up->port.type != PORT_SUNSAB)
		return -1;

		printk("Console: ttyS%d (SAB82532)\n",
		(sunsab_reg.minor - 64) + con->index);

Admin message