Commit 0f414212 authored Jul 21, 2015 by Murali Karicheri Committed by Bjorn Helgaas Jul 23, 2015

PCI: designware: Don't complain missing config reg space if va_cfg0 is set



Currently on Keystone SoCs, we always complain:

  keystone-pcie 21021000.pcie: missing *config* reg space

Keystone uses an older version of DesignWare hardware that doesn't have
ATU support.  So va_cfg0_base and va_cfg1_base are already set up in
ks_dw_pcie_host_init() before calling dw_pcie_host_init(), and they point
to the remote config space address va (both same for Keystone).  Add a
check to avoid this boot noise on Keystone.

Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

parent bc0195aa

drivers/pci/host/pcie-designware.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -388,7 +388,7 @@ int dw_pcie_host_init(struct pcie_port *pp)
		addrp = of_get_address(np, index, NULL, NULL);
		pp->cfg0_mod_base = of_read_number(addrp, ns);
		pp->cfg1_mod_base = pp->cfg0_mod_base + pp->cfg0_size;
		} else {
		} else if (!pp->va_cfg0_base) {
		dev_err(pp->dev, "missing config reg space\n");
		}

Admin message