Commit 0f2c5945 authored Oct 23, 2008 by Jiri Slaby Committed by Jiri Kosina Oct 23, 2008

HID: fix lock imbalance in hidraw



Add omitted unlock_kernel() to hidraw_ioctl().
Added in 979c407e
(HID: Push down BKL into ioctl handler in hidraw).

Corresponing sparse warning:
drivers/hid/hidraw.c:267:9: warning: context imbalance in 'hidraw_ioctl': wrong count at exit
drivers/hid/hidraw.c:267:9:    context 'kernel_lock': wanted 0, got 1

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent b4d8e473

drivers/hid/hidraw.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -264,6 +264,7 @@ static long hidraw_ioctl(struct file *file, unsigned int cmd,
		default:
		ret = -ENOTTY;
		}
		unlock_kernel();
		return ret;
		}

Admin message