Commit 0f15c53d authored May 07, 2010 by Chuck Lever Committed by Trond Myklebust May 14, 2010

NFS: Squelch compiler warning



Seen with -Wextra:

/home/cel/linux/fs/nfs/fscache.c: In function ‘__nfs_readpages_from_fscache’:
/home/cel/linux/fs/nfs/fscache.c:479: warning: comparison between signed and unsigned integer expressions

The comparison implicitly converts "int" to "unsigned", making it
safe.  But there's no need for the implicit type conversions here, and
the dfprintk() already uses a "%u" formatter for "npages."  Better to
reduce confusion.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

parent 9605a069

fs/nfs/fscache.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -467,7 +467,8 @@ int __nfs_readpages_from_fscache(struct nfs_open_context *ctx,
		struct list_head *pages,
		unsigned *nr_pages)
		{
		int ret, npages = *nr_pages;
		unsigned npages = *nr_pages;
		int ret;

		dfprintk(FSCACHE, "NFS: nfs_getpages_from_fscache (0x%p/%u/0x%p)\n",
		NFS_I(inode)->fscache, npages, inode);

Admin message