ARM64: kernel: unify ACPI and DT cpus initialization (0f078336) · Commits · 戴 / test

arch/arm64/include/asm/acpi.h

+4 −0

Original line number	Diff line number	Diff line
		@@ -93,4 +93,8 @@ static inline bool acpi_psci_use_hvc(void) { return false; }
		static inline void acpi_init_cpus(void) { }
		#endif /* CONFIG_ACPI */

		static inline const char *acpi_get_enable_method(int cpu)
		{
		return acpi_psci_present() ? "psci" : NULL;
		}
		#endif /_ASM_ACPI_H/

arch/arm64/include/asm/cpu_ops.h

+0 −1

Original line number	Diff line number	Diff line
		@@ -65,7 +65,6 @@ struct cpu_operations {

		extern const struct cpu_operations *cpu_ops[NR_CPUS];
		int __init cpu_read_ops(int cpu);
		const struct cpu_operations cpu_get_ops(const char name);

		static inline void __init cpu_read_bootcpu_ops(void)
		{

arch/arm64/include/asm/smp.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -42,7 +42,7 @@ extern void handle_IPI(int ipinr, struct pt_regs *regs);
		* Discover the set of possible CPUs and determine their
		* SMP operations.
		*/
		extern void of_smp_init_cpus(void);
		extern void smp_init_cpus(void);

		/*
		* Provide a function to raise an IPI cross call on CPUs in callmap.

arch/arm64/kernel/acpi.c

+0 −124

Original line number	Diff line number	Diff line
		@@ -36,12 +36,6 @@ EXPORT_SYMBOL(acpi_disabled);
		int acpi_pci_disabled = 1; /* skip ACPI PCI scan and IRQ initialization */
		EXPORT_SYMBOL(acpi_pci_disabled);

		/* Processors with enabled flag and sane MPIDR */
		static int enabled_cpus;

		/* Boot CPU is valid or not in MADT */
		static bool bootcpu_valid __initdata;

		static bool param_acpi_off __initdata;
		static bool param_acpi_force __initdata;

		@@ -95,124 +89,6 @@ void __init __acpi_unmap_table(char *map, unsigned long size)
		early_memunmap(map, size);
		}

		/**
		* acpi_map_gic_cpu_interface - generates a logical cpu number
		* and map to MPIDR represented by GICC structure
		*/
		static void __init
		acpi_map_gic_cpu_interface(struct acpi_madt_generic_interrupt *processor)
		{
		int i;
		u64 mpidr = processor->arm_mpidr & MPIDR_HWID_BITMASK;
		bool enabled = !!(processor->flags & ACPI_MADT_ENABLED);

		if (mpidr == INVALID_HWID) {
		pr_info("Skip MADT cpu entry with invalid MPIDR\n");
		return;
		}

		total_cpus++;
		if (!enabled)
		return;

		if (enabled_cpus >= NR_CPUS) {
		pr_warn("NR_CPUS limit of %d reached, Processor %d/0x%llx ignored.\n",
		NR_CPUS, total_cpus, mpidr);
		return;
		}

		/* Check if GICC structure of boot CPU is available in the MADT */
		if (cpu_logical_map(0) == mpidr) {
		if (bootcpu_valid) {
		pr_err("Firmware bug, duplicate CPU MPIDR: 0x%llx in MADT\n",
		mpidr);
		return;
		}

		bootcpu_valid = true;
		}

		/*
		* Duplicate MPIDRs are a recipe for disaster. Scan
		* all initialized entries and check for
		* duplicates. If any is found just ignore the CPU.
		*/
		for (i = 1; i < enabled_cpus; i++) {
		if (cpu_logical_map(i) == mpidr) {
		pr_err("Firmware bug, duplicate CPU MPIDR: 0x%llx in MADT\n",
		mpidr);
		return;
		}
		}

		if (!acpi_psci_present())
		return;

		cpu_ops[enabled_cpus] = cpu_get_ops("psci");
		/* CPU 0 was already initialized */
		if (enabled_cpus) {
		if (!cpu_ops[enabled_cpus])
		return;

		if (cpu_ops[enabled_cpus]->cpu_init(enabled_cpus))
		return;

		/* map the logical cpu id to cpu MPIDR */
		cpu_logical_map(enabled_cpus) = mpidr;
		}

		enabled_cpus++;
		}

		static int __init
		acpi_parse_gic_cpu_interface(struct acpi_subtable_header *header,
		const unsigned long end)
		{
		struct acpi_madt_generic_interrupt *processor;

		processor = (struct acpi_madt_generic_interrupt *)header;

		if (BAD_MADT_ENTRY(processor, end))
		return -EINVAL;

		acpi_table_print_madt_entry(header);
		acpi_map_gic_cpu_interface(processor);
		return 0;
		}

		/* Parse GIC cpu interface entries in MADT for SMP init */
		void __init acpi_init_cpus(void)
		{
		int count, i;

		/*
		* do a partial walk of MADT to determine how many CPUs
		* we have including disabled CPUs, and get information
		* we need for SMP init
		*/
		count = acpi_table_parse_madt(ACPI_MADT_TYPE_GENERIC_INTERRUPT,
		acpi_parse_gic_cpu_interface, 0);

		if (!count) {
		pr_err("No GIC CPU interface entries present\n");
		return;
		} else if (count < 0) {
		pr_err("Error parsing GIC CPU interface entry\n");
		return;
		}

		if (!bootcpu_valid) {
		pr_err("MADT missing boot CPU MPIDR, not enabling secondaries\n");
		return;
		}

		for (i = 0; i < enabled_cpus; i++)
		set_cpu_possible(i, true);

		/* Make boot-up look pretty */
		pr_info("%d CPUs enabled, %d CPUs total\n", enabled_cpus, total_cpus);
		}

		/*
		* acpi_fadt_sanity_check() - Check FADT presence and carry out sanity
		* checks on it

arch/arm64/kernel/cpu_ops.c

+41 −24

Original line number	Diff line number	Diff line
		@@ -16,11 +16,13 @@
		* along with this program. If not, see <http://www.gnu.org/licenses/>.
		*/

		#include <asm/cpu_ops.h>
		#include <asm/smp_plat.h>
		#include <linux/acpi.h>
		#include <linux/errno.h>
		#include <linux/of.h>
		#include <linux/string.h>
		#include <asm/acpi.h>
		#include <asm/cpu_ops.h>
		#include <asm/smp_plat.h>

		extern const struct cpu_operations smp_spin_table_ops;
		extern const struct cpu_operations cpu_psci_ops;
		@@ -35,7 +37,7 @@ static const struct cpu_operations *supported_cpu_ops[] __initconst = {
		NULL,
		};

		const struct cpu_operations * __init cpu_get_ops(const char *name)
		static const struct cpu_operations * __init cpu_get_ops(const char *name)
		{
		const struct cpu_operations **ops = supported_cpu_ops;

		@@ -49,36 +51,51 @@ const struct cpu_operations * __init cpu_get_ops(const char *name)
		return NULL;
		}

		/*
		* Read a cpu's enable method from the device tree and record it in cpu_ops.
		*/
		int __init cpu_read_ops(int cpu)
		static const char *__init cpu_read_enable_method(int cpu)
		{
		const char *enable_method;

		if (acpi_disabled) {
		struct device_node *dn = of_get_cpu_node(cpu, NULL);

		if (!dn) {
		if (!cpu)
		pr_err("Failed to find device node for boot cpu\n");
		return -ENODEV;
		return NULL;
		}

		enable_method = of_get_property(dn, "enable-method", NULL);
		if (!enable_method) {
		/*
		* The boot CPU may not have an enable method (e.g. when
		* spin-table is used for secondaries). Don't warn spuriously.
		* The boot CPU may not have an enable method (e.g.
		* when spin-table is used for secondaries).
		* Don't warn spuriously.
		*/
		if (cpu != 0)
		pr_err("%s: missing enable-method property\n",
		dn->full_name);
		return -ENOENT;
		}
		} else {
		enable_method = acpi_get_enable_method(cpu);
		if (!enable_method)
		pr_err("Unsupported ACPI enable-method\n");
		}

		return enable_method;
		}
		/*
		* Read a cpu's enable method and record it in cpu_ops.
		*/
		int __init cpu_read_ops(int cpu)
		{
		const char *enable_method = cpu_read_enable_method(cpu);

		if (!enable_method)
		return -ENODEV;

		cpu_ops[cpu] = cpu_get_ops(enable_method);
		if (!cpu_ops[cpu]) {
		pr_warn("%s: unsupported enable-method property: %s\n",
		dn->full_name, enable_method);
		pr_warn("Unsupported enable-method: %s\n", enable_method);
		return -EOPNOTSUPP;
		}

Admin message