Commit 0f04d057 authored Nov 03, 2017 by Colin Ian King Committed by David S. Miller Nov 04, 2017

net: sched: cls_u32: use bitwise & rather than logical && on n->flags



Currently n->flags is being operated on by a logical && operator rather
than a bitwise & operator. This looks incorrect as these should be bit
flag operations. Fix this.

Detected by CoverityScan, CID#1460398 ("Logical vs. bitwise operator")

Fixes: 245dc512 ("net: sched: cls_u32: call block callbacks for offload")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 991a26af

net/sched/cls_u32.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -572,7 +572,7 @@ static int u32_replace_hw_knode(struct tcf_proto tp, struct tc_u_knode n,
		n->flags \|= TCA_CLS_FLAGS_IN_HW;
		}

		if (skip_sw && !(n->flags && TCA_CLS_FLAGS_IN_HW))
		if (skip_sw && !(n->flags & TCA_CLS_FLAGS_IN_HW))
		return -EINVAL;

		return 0;

Admin message