Commit 0ef46e28 authored Sep 18, 2008 by Vlad Yasevich Committed by David S. Miller Sep 18, 2008

sctp: do not enable peer features if we can't do them.



Do not enable peer features like addip and auth, if they
are administratively disabled localy.  If the peer resports
that he supports something that we don't, neither end can
use it so enabling it is pointless.  This solves a problem
when talking to a peer that has auth and addip enabled while
we do not.  Found by Andrei Pelinescu-Onciul <andrei@iptel.org>.

Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent a3028b8e

net/sctp/sm_make_chunk.c

+7 −2

Original line number	Diff line number	Diff line
		@@ -1886,10 +1886,12 @@ static void sctp_process_ext_param(struct sctp_association *asoc,
		/* if the peer reports AUTH, assume that he
		* supports AUTH.
		*/
		if (sctp_auth_enable)
		asoc->peer.auth_capable = 1;
		break;
		case SCTP_CID_ASCONF:
		case SCTP_CID_ASCONF_ACK:
		if (sctp_addip_enable)
		asoc->peer.asconf_capable = 1;
		break;
		default:
		@@ -2460,6 +2462,9 @@ do_addr_param:
		break;

		case SCTP_PARAM_SET_PRIMARY:
		if (!sctp_addip_enable)
		goto fall_through;

		addr_param = param.v + sizeof(sctp_addip_param_t);

		af = sctp_get_af_specific(param_type2af(param.p->type));

Admin message