Commit 0eecc619 authored Apr 08, 2019 by Philipp Zabel Committed by Mauro Carvalho Chehab Apr 22, 2019

media: coda: throw error on create_bufs with too small size

If VIDIOC_CREATE_BUFS is called with a sizeimage smaller than the
queue sizeimage, fail with -EINVAL instead of correcting the size
and continuing without error. This is required by v4l2-compliance.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

parent 01ba2e65

drivers/media/platform/coda/coda-common.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -1501,6 +1501,9 @@ static int coda_queue_setup(struct vb2_queue *vq,
		q_data = get_q_data(ctx, vq->type);
		size = q_data->sizeimage;

		if (*nplanes)
		return sizes[0] < size ? -EINVAL : 0;

		*nplanes = 1;
		sizes[0] = size;