Commit 0ee9608c authored Nov 05, 2015 by Daniel Borkmann Committed by Al Viro Nov 11, 2015

debugfs: fix refcount imbalance in start_creating



In debugfs' start_creating(), we pin the file system to safely access
its root. When we failed to create a file, we unpin the file system via
failed_creating() to release the mount count and eventually the reference
of the vfsmount.

However, when we run into an error during lookup_one_len() when still
in start_creating(), we only release the parent's mutex but not so the
reference on the mount. Looks like it was done in the past, but after
splitting portions of __create_file() into start_creating() and
end_creating() via 190afd81 ("debugfs: split the beginning and the
end of __create_file() off"), this seemed missed. Noticed during code
review.

Fixes: 190afd81 ("debugfs: split the beginning and the end of __create_file() off")
Cc: stable@vger.kernel.org # v4.0+
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

parent ce5c2d2c

fs/debugfs/inode.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -271,8 +271,12 @@ static struct dentry start_creating(const char name, struct dentry *parent)
		dput(dentry);
		dentry = ERR_PTR(-EEXIST);
		}
		if (IS_ERR(dentry))

		if (IS_ERR(dentry)) {
		mutex_unlock(&d_inode(parent)->i_mutex);
		simple_release_fs(&debugfs_mount, &debugfs_mount_count);
		}

		return dentry;
		}

Admin message