Commit 0ee13627 authored Jun 14, 2016 by Florian Westphal Committed by David S. Miller Jun 15, 2016

htb: call qdisc_root with rcu read lock held



saw a debug splat:
net/include/net/sch_generic.h:287 suspicious rcu_dereference_check() usage!
other info that might help us debug this:
rcu_scheduler_active = 1, debug_locks = 0
 2 locks held by kworker/2:1/710:
  #0:  ("events"){.+.+.+}, at: [<ffffffff8106ca1d>]
  #1:  ((&q->work)){+.+...}, at: [<ffffffff8106ca1d>] process_one_work+0x14d/0x690
Workqueue: events htb_work_func
Call Trace:
 [<ffffffff812dc763>] dump_stack+0x85/0xc2
 [<ffffffff8109fee7>] lockdep_rcu_suspicious+0xe7/0x120
 [<ffffffff814ced47>] htb_work_func+0x67/0x70

Signed-off-by: Florian Westphal <fw@strlen.de>
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent ebecaa66

net/sched/sch_htb.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1007,7 +1007,9 @@ static void htb_work_func(struct work_struct *work)
		struct htb_sched *q = container_of(work, struct htb_sched, work);
		struct Qdisc *sch = q->watchdog.qdisc;

		rcu_read_lock();
		__netif_schedule(qdisc_root(sch));
		rcu_read_unlock();
		}

		static int htb_init(struct Qdisc sch, struct nlattr opt)

Admin message