Commit 0ec96822 authored May 03, 2007 by Ilpo Järvinen Committed by David S. Miller May 03, 2007

[TCP]: Use S+L catcher only with SACK for now



TCP has a transitional state when SACK is not in use during
which this invariant is temporarily broken. Without SACK,
tcp_clean_rtx_queue does not decrement sacked_out. Therefore
calls to tcp_sync_left_out before sacked_out is again
corrected by tcp_fastretrans_alert can trigger this trap as
sacked_out still has couple of segments that are already out
of window.

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent ec9c9485

include/net/tcp.h

+2 −1

Original line number	Diff line number	Diff line
		@@ -736,7 +736,8 @@ static inline __u32 tcp_current_ssthresh(const struct sock *sk)

		static inline void tcp_sync_left_out(struct tcp_sock *tp)
		{
		BUG_ON(tp->sacked_out + tp->lost_out > tp->packets_out);
		BUG_ON(tp->rx_opt.sack_ok &&
		(tp->sacked_out + tp->lost_out > tp->packets_out));
		tp->left_out = tp->sacked_out + tp->lost_out;
		}

Admin message