spi: spi-mem: Add SPI_MEM_NO_DATA to the spi_mem_data_dir enum (0ebb261a) · Commits · 戴 / test

When defining spi_mem_op templates we don't necessarily know the size that will be passed when the template is actually used, and basing the supports_op() check on op->data.nbytes to know whether there will be data transferred for a specific operation is this not possible. Add SPI_MEM_NO_DATA to the spi_mem_data_dir enum so that we can base our checks on op->data.dir instead of op->data.nbytes. Signed-off-by:

Boris Brezillon <boris.brezillon@bootlin.com> Reviewed-by:

Miquel Raynal <miquel.raynal@bootlin.com> Signed-off-by:

Mark Brown <broonie@kernel.org>

drivers/spi/spi-mem.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -142,7 +142,7 @@ static bool spi_mem_default_supports_op(struct spi_mem *mem,
		spi_check_buswidth_req(mem, op->dummy.buswidth, true))
		return false;

		if (op->data.nbytes &&
		if (op->data.dir != SPI_MEM_NO_DATA &&
		spi_check_buswidth_req(mem, op->data.buswidth,
		op->data.dir == SPI_MEM_DATA_OUT))
		return false;

include/linux/spi/spi-mem.h

+2 −0

Original line number	Diff line number	Diff line
		@@ -57,10 +57,12 @@
		/**
		* enum spi_mem_data_dir - describes the direction of a SPI memory data
		* transfer from the controller perspective
		* @SPI_MEM_NO_DATA: no data transferred
		* @SPI_MEM_DATA_IN: data coming from the SPI memory
		* @SPI_MEM_DATA_OUT: data sent to the SPI memory
		*/
		enum spi_mem_data_dir {
		SPI_MEM_NO_DATA,
		SPI_MEM_DATA_IN,
		SPI_MEM_DATA_OUT,
		};

Admin message