f2fs: read page index before freeing (0ea295dd) · Commits · 戴 / test

The function truncate_node frees the page with f2fs_put_page. However, the page index is read after that. So, the patch reads the index before freeing the page. Fixes: ("f2fs: drop obsolete node page when it is truncated") Cc: <stable@vger.kernel.org> Signed-off-by:

Pan Bian <bianpan2016@163.com> Reviewed-by:

Chao Yu <yuchao0@huawei.com> Signed-off-by:

Jaegeuk Kim <jaegeuk@kernel.org>

fs/f2fs/node.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -826,6 +826,7 @@ static int truncate_node(struct dnode_of_data *dn)
		struct f2fs_sb_info *sbi = F2FS_I_SB(dn->inode);
		struct node_info ni;
		int err;
		pgoff_t index;

		err = f2fs_get_node_info(sbi, dn->nid, &ni);
		if (err)
		@@ -845,10 +846,11 @@ static int truncate_node(struct dnode_of_data *dn)
		clear_node_page_dirty(dn->node_page);
		set_sbi_flag(sbi, SBI_IS_DIRTY);

		index = dn->node_page->index;
		f2fs_put_page(dn->node_page, 1);

		invalidate_mapping_pages(NODE_MAPPING(sbi),
		dn->node_page->index, dn->node_page->index);
		index, index);

		dn->node_page = NULL;
		trace_f2fs_truncate_node(dn->inode, dn->nid, ni.blk_addr);

Admin message