Commit 0e98c084 authored Dec 04, 2019 by zhangyi (F) Committed by Theodore Ts'o Jan 25, 2020

jbd2: make sure ESHUTDOWN to be recorded in the journal superblock



Commit fb7c0244 ("ext4: pass -ESHUTDOWN code to jbd2 layer") want
to allow jbd2 layer to distinguish shutdown journal abort from other
error cases. So the ESHUTDOWN should be taken precedence over any other
errno which has already been recoded after EXT4_FLAGS_SHUTDOWN is set,
but it only update errno in the journal suoerblock now if the old errno
is 0.

Fixes: fb7c0244 ("ext4: pass -ESHUTDOWN code to jbd2 layer")
Signed-off-by: zhangyi (F) <yi.zhang@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20191204124614.45424-4-yi.zhang@huawei.com


Signed-off-by: Theodore Ts'o <tytso@mit.edu>

parent 51f57b01

fs/jbd2/journal.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -2147,8 +2147,7 @@ static void __journal_abort_soft (journal_t *journal, int errno)

		if (journal->j_flags & JBD2_ABORT) {
		write_unlock(&journal->j_state_lock);
		if (!old_errno && old_errno != -ESHUTDOWN &&
		errno == -ESHUTDOWN)
		if (old_errno != -ESHUTDOWN && errno == -ESHUTDOWN)
		jbd2_journal_update_sb_errno(journal);
		return;
		}

Admin message