Commit 0e8edb9a authored Jan 13, 2017 by Arnd Bergmann Committed by Kalle Valo Jan 17, 2017

mwifiex: fix uninitialized variable access in pcie_remove

Checking the firmware status from PCIe register only works
if the register is available, otherwise we end up with
random behavior:

drivers/net/wireless/marvell/mwifiex/pcie.c: In function 'mwifiex_pcie_remove':
drivers/net/wireless/marvell/mwifiex/pcie.c:585:5: error: 'fw_status' may be used uninitialized in this function [-Werror=maybe-uninitialized]

This makes sure we treat the absence of the register as a failure.

Fixes: 045f0c1b ("mwifiex: get rid of global user_rmmod flag")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

parent cc75c577

drivers/net/wireless/marvell/mwifiex/pcie.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -299,6 +299,8 @@ static void mwifiex_pcie_remove(struct pci_dev *pdev)
		reg = card->pcie.reg;
		if (reg)
		ret = mwifiex_read_reg(adapter, reg->fw_status, &fw_status);
		else
		fw_status = -1;

		if (fw_status == FIRMWARE_READY_PCIE && !adapter->mfg_mode) {
		mwifiex_deauthenticate_all(adapter);

Admin message