Commit 0e8d2b0f authored Nov 24, 2016 by Dan Carpenter Committed by Jonathan Cameron Nov 24, 2016

iio: tsl2583: make array large enough



This array is supposed to have 10 elements.  Smatch complains that with
the current code we can have n == max_ints and read beyond the end of
the array.

Fixes: ac4f6eee ("staging: iio: TAOS tsl258x: Device driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Brian Masney <masneyb@onstation.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>

parent 9049531c

drivers/iio/light/tsl2583.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -565,7 +565,7 @@ static ssize_t in_illuminance_lux_table_store(struct device *dev,
		struct iio_dev *indio_dev = dev_to_iio_dev(dev);
		struct tsl2583_chip *chip = iio_priv(indio_dev);
		const unsigned int max_ints = TSL2583_MAX_LUX_TABLE_ENTRIES * 3;
		int value[TSL2583_MAX_LUX_TABLE_ENTRIES * 3];
		int value[TSL2583_MAX_LUX_TABLE_ENTRIES * 3 + 1];
		int ret = -EINVAL;
		unsigned int n;

Admin message