Commit 0e86d981 authored Apr 22, 2020 by Kunihiko Hayashi Committed by Lorenzo Pieralisi May 05, 2020

PCI: endpoint: functions/pci-epf-test: Fix DMA channel release

When unbinding pci_epf_test, pci_epf_test_clean_dma_chan() is called in
pci_epf_test_unbind() even though epf_test->dma_supported is false.

As a result, dma_release_channel() will trigger a NULL pointer
dereference because dma_chan is not set.

Avoid calling dma_release_channel() if epf_test->dma_supported
is false.

Link: https://lore.kernel.org/r/1587540287-10458-1-git-send-email-hayashi.kunihiko@socionext.com


Fixes: 5ebf3fc5 ("PCI: endpoint: functions/pci-epf-test: Add DMA support to transfer data")
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
[lorenzo.pieralisi@arm.com: commit log]
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>

parent 8f3d9f35

drivers/pci/endpoint/functions/pci-epf-test.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -187,6 +187,9 @@ static int pci_epf_test_init_dma_chan(struct pci_epf_test *epf_test)
		*/
		static void pci_epf_test_clean_dma_chan(struct pci_epf_test *epf_test)
		{
		if (!epf_test->dma_supported)
		return;

		dma_release_channel(epf_test->dma_chan);
		epf_test->dma_chan = NULL;
		}

Admin message