Commit 0e83fc61 authored Mar 20, 2019 by Luo Jiaxing Committed by Martin K. Petersen Mar 20, 2019

scsi: hisi_sas: Add softreset in hisi_sas_I_T_nexus_reset()



We found out that for v2 hw, a SATA disk can not be written to after the
system comes up.

In commit ffb1c820 ("scsi: hisi_sas: remove the check of sas_dev status
in hisi_sas_I_T_nexus_reset()"), we introduced a path where we may issue an
internal abort for a SATA device, but without following it with a
softreset.

We need to always follow an internal abort with a software reset, as per HW
programming flow, so add this.

Fixes: ffb1c820 ("scsi: hisi_sas: remove the check of sas_dev status in hisi_sas_I_T_nexus_reset()")
Signed-off-by: Luo Jiaxing <luojiaxing@huawei.com>
Signed-off-by: John Garry <john.garry@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent ac444b4f

drivers/scsi/hisi_sas/hisi_sas_main.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -1801,6 +1801,12 @@ static int hisi_sas_I_T_nexus_reset(struct domain_device *device)
		}
		hisi_sas_dereg_device(hisi_hba, device);

		if (dev_is_sata(device)) {
		rc = hisi_sas_softreset_ata_disk(device);
		if (rc)
		return TMF_RESP_FUNC_FAILED;
		}

		rc = hisi_sas_debug_I_T_nexus_reset(device);

		if ((rc == TMF_RESP_FUNC_COMPLETE) \|\| (rc == -ENODEV))

Admin message