Commit 0e835087 authored by Dan Carpenter's avatar Dan Carpenter Committed by Mauro Carvalho Chehab
Browse files

[media] lirc_dev: add some __user annotations 



Sparse complains because there are no __user annotations.

drivers/media/rc/lirc_dev.c:156:27: warning:
	incorrect type in initializer (incompatible argument 2 (different address spaces))
drivers/media/rc/lirc_dev.c:156:27:    expected int ( *read )( ... )
drivers/media/rc/lirc_dev.c:156:27:    got int ( extern [toplevel] *<noident> )( ... )

Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Acked-by: default avatarJarod Wilson <jarod@redhat.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 829ba9fe

drivers/media/rc/lirc_dev.c

+2 −2
Original line number Diff line number Diff line
@@ -627,7 +627,7 @@ long lirc_dev_fop_ioctl(struct file *file, unsigned int cmd, unsigned long arg) 
EXPORT_SYMBOL(lirc_dev_fop_ioctl);



ssize_t lirc_dev_fop_read(struct file *file,

			  char *buffer,

			  char __user *buffer,

			  size_t length,

			  loff_t *ppos)

{
@@ -747,7 +747,7 @@ void *lirc_get_pdata(struct file *file) 
EXPORT_SYMBOL(lirc_get_pdata);





ssize_t lirc_dev_fop_write(struct file *file, const char *buffer,

ssize_t lirc_dev_fop_write(struct file *file, const char __user *buffer,

			   size_t length, loff_t *ppos)

{

	struct irctl *ir = irctls[iminor(file->f_dentry->d_inode)];

include/media/lirc_dev.h

+3 −3
Original line number Diff line number Diff line
@@ -217,9 +217,9 @@ int lirc_dev_fop_open(struct inode *inode, struct file *file); 
int lirc_dev_fop_close(struct inode *inode, struct file *file);

unsigned int lirc_dev_fop_poll(struct file *file, poll_table *wait);

long lirc_dev_fop_ioctl(struct file *file, unsigned int cmd, unsigned long arg);

ssize_t lirc_dev_fop_read(struct file *file, char *buffer, size_t length,

			  loff_t *ppos);

ssize_t lirc_dev_fop_write(struct file *file, const char *buffer, size_t length,

ssize_t lirc_dev_fop_read(struct file *file, char __user *buffer, size_t length,

			  loff_t *ppos);

ssize_t lirc_dev_fop_write(struct file *file, const char __user *buffer,

			   size_t length, loff_t *ppos);



#endif

CRA Git | Maintained and supported by SUSTech CRA and CCSE