Commit 0e7da29d authored by Tudor-Dan Ambarus's avatar Tudor-Dan Ambarus Committed by Herbert Xu
Browse files

crypto: ixp4xx - don't leak pointers to authenc keys 



In ixp4xx's aead_setkey we save pointers to the authenc keys in a
local variable of type struct crypto_authenc_keys and we don't
zeroize it after use. Fix this and don't leak pointers to the
authenc keys.

Signed-off-by: default avatarTudor Ambarus <tudor.ambarus@microchip.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent eb526531

drivers/crypto/ixp4xx_crypto.c

+2 −0
Original line number Original line Diff line number Diff line
@@ -1167,9 +1167,11 @@ static int aead_setkey(struct crypto_aead *tfm, const u8 *key, 
	ctx->authkey_len = keys.authkeylen;

	ctx->authkey_len = keys.authkeylen;

	ctx->enckey_len = keys.enckeylen;

	ctx->enckey_len = keys.enckeylen;





	memzero_explicit(&keys, sizeof(keys));

	return aead_setup(tfm, crypto_aead_authsize(tfm));

	return aead_setup(tfm, crypto_aead_authsize(tfm));

badkey:

badkey:

	crypto_aead_set_flags(tfm, CRYPTO_TFM_RES_BAD_KEY_LEN);

	crypto_aead_set_flags(tfm, CRYPTO_TFM_RES_BAD_KEY_LEN);

	memzero_explicit(&keys, sizeof(keys));

	return -EINVAL;

	return -EINVAL;

}

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE