dmaengine: xgene: convert tasklets to use new tasklet_setup() API (0e71d9b9) · Commits · 戴 / test

In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by:

Romain Perier <romain.perier@gmail.com> Signed-off-by:

Allen Pais <allen.lkml@gmail.com> Link: https://lore.kernel.org/r/20200831103542.305571-32-allen.lkml@gmail.com Signed-off-by:

Vinod Koul <vkoul@kernel.org>

drivers/dma/xgene-dma.c

+3 −4

Original line number	Diff line number	Diff line
		@@ -975,9 +975,9 @@ static enum dma_status xgene_dma_tx_status(struct dma_chan *dchan,
		return dma_cookie_status(dchan, cookie, txstate);
		}

		static void xgene_dma_tasklet_cb(unsigned long data)
		static void xgene_dma_tasklet_cb(struct tasklet_struct *t)
		{
		struct xgene_dma_chan chan = (struct xgene_dma_chan )data;
		struct xgene_dma_chan *chan = from_tasklet(chan, t, tasklet);

		/* Run all cleanup for descriptors which have been completed */
		xgene_dma_cleanup_descriptors(chan);
		@@ -1539,8 +1539,7 @@ static int xgene_dma_async_register(struct xgene_dma *pdma, int id)
		INIT_LIST_HEAD(&chan->ld_pending);
		INIT_LIST_HEAD(&chan->ld_running);
		INIT_LIST_HEAD(&chan->ld_completed);
		tasklet_init(&chan->tasklet, xgene_dma_tasklet_cb,
		(unsigned long)chan);
		tasklet_setup(&chan->tasklet, xgene_dma_tasklet_cb);

		chan->pending = 0;
		chan->desc_pool = NULL;

Admin message