Commit 0e6e255e authored Jul 07, 2020 by Christoph Hellwig Committed by Jens Axboe Jul 07, 2020

block: remove a bogus warning in __submit_bio_noacct_mq



If blk_mq_submit_bio flushes the plug list, bios for other disks can
show up on current->bio_list.  As that doesn't involve any stacking of
block device it is entirely harmless and we should not warn about
this case.

Fixes: ff93ea0c ("block: shortcut __submit_bio_noacct for blk-mq drivers")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 7c792f33

block/blk-core.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -1154,14 +1154,13 @@ static blk_qc_t __submit_bio_noacct(struct bio *bio)

		static blk_qc_t __submit_bio_noacct_mq(struct bio *bio)
		{
		struct gendisk *disk = bio->bi_disk;
		struct bio_list bio_list[2] = { };
		blk_qc_t ret = BLK_QC_T_NONE;

		current->bio_list = bio_list;

		do {
		WARN_ON_ONCE(bio->bi_disk != disk);
		struct gendisk *disk = bio->bi_disk;

		if (unlikely(bio_queue_enter(bio) != 0))
		continue;

Admin message