Commit 0e3da5bb authored Dec 16, 2013 by Timo Teräs Committed by David S. Miller Dec 18, 2013

ip_gre: fix msg_name parsing for recvfrom/recvmsg



ipgre_header_parse() needs to parse the tunnel's ip header and it
uses mac_header to locate the iphdr. This got broken when gre tunneling
was refactored as mac_header is no longer updated to point to iphdr.
Introduce skb_pop_mac_header() helper to do the mac_header assignment
and use it in ipgre_rcv() to fix msg_name parsing.

Bug introduced in commit c5441932 (GRE: Refactor GRE tunneling code.)

Cc: Pravin B Shelar <pshelar@nicira.com>
Signed-off-by: Timo Teräs <timo.teras@iki.fi>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent a81d8762

include/linux/skbuff.h

+5 −0

Original line number	Diff line number	Diff line
		@@ -1638,6 +1638,11 @@ static inline void skb_set_mac_header(struct sk_buff *skb, const int offset)
		skb->mac_header += offset;
		}

		static inline void skb_pop_mac_header(struct sk_buff *skb)
		{
		skb->mac_header = skb->network_header;
		}

		static inline void skb_probe_transport_header(struct sk_buff *skb,
		const int offset_hint)
		{

net/ipv4/ip_gre.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -217,6 +217,7 @@ static int ipgre_rcv(struct sk_buff skb, const struct tnl_ptk_info tpi)
		iph->saddr, iph->daddr, tpi->key);

		if (tunnel) {
		skb_pop_mac_header(skb);
		ip_tunnel_rcv(tunnel, skb, tpi, log_ecn_error);
		return PACKET_RCVD;
		}

Admin message