net: sched: return error code when tcf proto is not found (0e399035) · Commits · 戴 / test

If requested tcf proto is not found, get and del filter netlink protocol handlers output error message to extack, but do not return actual error code. Add check to return ENOENT when result of tp find function is NULL pointer. Fixes: ("net: sched: split tc_ctl_tfilter into three handlers") Reported-by:

Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:

Vlad Buslov <vladbu@mellanox.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

net/sched/cls_api.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1274,7 +1274,7 @@ static int tc_del_tfilter(struct sk_buff skb, struct nlmsghdr n,
		prio, false);
		if (!tp \|\| IS_ERR(tp)) {
		NL_SET_ERR_MSG(extack, "Filter with specified priority/protocol not found");
		err = PTR_ERR(tp);
		err = tp ? PTR_ERR(tp) : -ENOENT;
		goto errout;
		} else if (tca[TCA_KIND] && nla_strcmp(tca[TCA_KIND], tp->ops->kind)) {
		NL_SET_ERR_MSG(extack, "Specified filter kind does not match existing one");
		@@ -1374,7 +1374,7 @@ static int tc_get_tfilter(struct sk_buff skb, struct nlmsghdr n,
		prio, false);
		if (!tp \|\| IS_ERR(tp)) {
		NL_SET_ERR_MSG(extack, "Filter with specified priority/protocol not found");
		err = PTR_ERR(tp);
		err = tp ? PTR_ERR(tp) : -ENOENT;
		goto errout;
		} else if (tca[TCA_KIND] && nla_strcmp(tca[TCA_KIND], tp->ops->kind)) {
		NL_SET_ERR_MSG(extack, "Specified filter kind does not match existing one");

Admin message