Commit 0e2bdb0e authored by Kishon Vijay Abraham I's avatar Kishon Vijay Abraham I Committed by Bjorn Helgaas
Browse files

PCI: dra7xx: Disable pm_runtime on get_sync failure 



Fix the error handling when pm_runtime_get_sync() fails.

If pm_runtime_get_sync() fails, call pm_runtime_disable() so there are no
unbalanced pm_runtime_enable() calls.

Signed-off-by: default avatarKishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarJingoo Han <jingoohan1@gmail.com>
parent bc0195aa

drivers/pci/host/pci-dra7xx.c

+3 −1
Original line number Diff line number Diff line
@@ -384,7 +384,7 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev) 
	ret = pm_runtime_get_sync(dev);

	if (IS_ERR_VALUE(ret)) {

		dev_err(dev, "pm_runtime_get_sync failed\n");

		goto err_phy;

		goto err_get_sync;

	}



	reg = dra7xx_pcie_readl(dra7xx, PCIECTRL_DRA7XX_CONF_DEVICE_CMD);
@@ -401,6 +401,8 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev) 


err_add_port:

	pm_runtime_put(dev);



err_get_sync:

	pm_runtime_disable(dev);



err_phy:

CRA Git | Maintained and supported by SUSTech CRA and CCSE