Commit 0e10d549 authored by Dan Carpenter's avatar Dan Carpenter Committed by Lee Jones
Browse files

mfd: wm8400-core: Delete wm8400_reg_read() 



There was a static checker warning in wm8400_reg_read() because we were
returning u16 and that can't hold the negative error codes.  The
function isn't used, so let's just delete it.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarCharles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent f83c218c

drivers/mfd/wm8400-core.c

+0 −21
Original line number Diff line number Diff line
@@ -35,27 +35,6 @@ static bool wm8400_volatile(struct device *dev, unsigned int reg) 
	}

}



/**

 * wm8400_reg_read - Single register read

 *

 * @wm8400: Pointer to wm8400 control structure

 * @reg:    Register to read

 *

 * @return  Read value

 */

u16 wm8400_reg_read(struct wm8400 *wm8400, u8 reg)

{

	unsigned int val;

	int ret;



	ret = regmap_read(wm8400->regmap, reg, &val);

	if (ret < 0)

		return ret;



	return val;

}

EXPORT_SYMBOL_GPL(wm8400_reg_read);



int wm8400_block_read(struct wm8400 *wm8400, u8 reg, int count, u16 *data)

{

	return regmap_bulk_read(wm8400->regmap, reg, data, count);

include/linux/mfd/wm8400-private.h

+0 −1
Original line number Diff line number Diff line
@@ -923,7 +923,6 @@ struct wm8400 { 
#define WM8400_LINE_CMP_VTHD_SHIFT                   0  /* LINE_CMP_VTHD - [3:0] */

#define WM8400_LINE_CMP_VTHD_WIDTH                   4  /* LINE_CMP_VTHD - [3:0] */



u16 wm8400_reg_read(struct wm8400 *wm8400, u8 reg);

int wm8400_block_read(struct wm8400 *wm8400, u8 reg, int count, u16 *data);



static inline int wm8400_set_bits(struct wm8400 *wm8400, u8 reg,

CRA Git | Maintained and supported by SUSTech CRA and CCSE