backlight: lm3630a: Add an enable gpio for the HWEN pin (0e0e78e3) · Commits · 戴 / test

For now just enable it in the probe function to allow I2C access. Disabling also means resetting the register values to default and according to the datasheet does not give power savings. Tested on Kobo Clara HD. Signed-off-by:

Andreas Kemnade <andreas@kemnade.info> Reviewed-by:

Dan Murphy <dmurphy@ti.com> Reviewed-by:

Daniel Thompson <daniel.thompson@linaro.org> Signed-off-by:

Lee Jones <lee.jones@linaro.org>

drivers/video/backlight/lm3630a_bl.c

+9 −0

Original line number	Diff line number	Diff line
		@@ -12,6 +12,7 @@
		#include <linux/uaccess.h>
		#include <linux/interrupt.h>
		#include <linux/regmap.h>
		#include <linux/gpio/consumer.h>
		#include <linux/pwm.h>
		#include <linux/platform_data/lm3630a_bl.h>

		@@ -48,6 +49,7 @@ struct lm3630a_chip {
		struct lm3630a_platform_data *pdata;
		struct backlight_device *bleda;
		struct backlight_device *bledb;
		struct gpio_desc *enable_gpio;
		struct regmap *regmap;
		struct pwm_device *pwmd;
		};
		@@ -534,6 +536,13 @@ static int lm3630a_probe(struct i2c_client *client,
		}
		pchip->pdata = pdata;

		pchip->enable_gpio = devm_gpiod_get_optional(&client->dev, "enable",
		GPIOD_OUT_HIGH);
		if (IS_ERR(pchip->enable_gpio)) {
		rval = PTR_ERR(pchip->enable_gpio);
		return rval;
		}

		/* chip initialize */
		rval = lm3630a_chip_init(pchip);
		if (rval < 0) {

Admin message