do_sigaltstack: small cleanups (0dd8486b) · Commits · 戴 / test

The previous commit ("do_sigaltstack: avoid copying 'stack_t' as a structure to user space") fixed a real bug. This one just cleans up the copy from user space to that gcc can generate better code for it (and so that it looks the same as the later copy back to user space). Signed-off-by:

Linus Torvalds <torvalds@linux-foundation.org>

kernel/signal.c

+6 −4

Original line number	Diff line number	Diff line
		@@ -2464,10 +2464,12 @@ do_sigaltstack (const stack_t __user uss, stack_t __user uoss, unsigned long s
		int ss_flags;

		error = -EFAULT;
		if (!access_ok(VERIFY_READ, uss, sizeof(*uss))
		\|\| __get_user(ss_sp, &uss->ss_sp)
		\|\| __get_user(ss_flags, &uss->ss_flags)
		\|\| __get_user(ss_size, &uss->ss_size))
		if (!access_ok(VERIFY_READ, uss, sizeof(*uss)))
		goto out;
		error = __get_user(ss_sp, &uss->ss_sp) \|
		__get_user(ss_flags, &uss->ss_flags) \|
		__get_user(ss_size, &uss->ss_size);
		if (error)
		goto out;

		error = -EPERM;

Admin message