mfd: wm8350-core: Drop unused module infrastructure from non-modular code (0db88688) · Commits · 戴 / test

The Kconfig currently controlling compilation of this code is: drivers/mfd/Kconfig:config MFD_WM8350 drivers/mfd/Kconfig: bool ...meaning that it currently is not being built as a module by anyone. Lets remove the couple traces of modular infrastructure use, so that when reading the driver there is no doubt it is builtin-only. We delete the MODULE_LICENSE tag etc. since all that information is already contained at the top of the file in the comments. We replace module.h with init.h and export.h ; the latter since the file does export some symbols. Previous demodularizaion work has made wm8350_device_exit() no longer used, so it is also removed from the 8350 core code. Signed-off-by:

Paul Gortmaker <paul.gortmaker@windriver.com> Acked-by:

Charles Keepax <ckeepax@opensource.cirrus.com> Signed-off-by:

Lee Jones <lee.jones@linaro.org>

drivers/mfd/wm8350-core.c

+2 −28

Original line number	Diff line number	Diff line
		@@ -13,7 +13,8 @@
		*/

		#include <linux/kernel.h>
		#include <linux/module.h>
		#include <linux/init.h>
		#include <linux/export.h>
		#include <linux/slab.h>
		#include <linux/bug.h>
		#include <linux/device.h>
		@@ -442,30 +443,3 @@ err:
		return ret;
		}
		EXPORT_SYMBOL_GPL(wm8350_device_init);

		void wm8350_device_exit(struct wm8350 *wm8350)
		{
		int i;

		for (i = 0; i < ARRAY_SIZE(wm8350->pmic.led); i++)
		platform_device_unregister(wm8350->pmic.led[i].pdev);

		for (i = 0; i < ARRAY_SIZE(wm8350->pmic.pdev); i++)
		platform_device_unregister(wm8350->pmic.pdev[i]);

		platform_device_unregister(wm8350->wdt.pdev);
		platform_device_unregister(wm8350->rtc.pdev);
		platform_device_unregister(wm8350->power.pdev);
		platform_device_unregister(wm8350->hwmon.pdev);
		platform_device_unregister(wm8350->gpio.pdev);
		platform_device_unregister(wm8350->codec.pdev);

		if (wm8350->irq_base)
		free_irq(wm8350->irq_base + WM8350_IRQ_AUXADC_DATARDY, wm8350);

		wm8350_irq_exit(wm8350);
		}
		EXPORT_SYMBOL_GPL(wm8350_device_exit);

		MODULE_DESCRIPTION("WM8350 AudioPlus PMIC core driver");
		MODULE_LICENSE("GPL");

include/linux/mfd/wm8350/core.h

+0 −1

Original line number	Diff line number	Diff line
		@@ -643,7 +643,6 @@ struct wm8350_platform_data {
		*/
		int wm8350_device_init(struct wm8350 *wm8350, int irq,
		struct wm8350_platform_data *pdata);
		void wm8350_device_exit(struct wm8350 *wm8350);

		/*
		* WM8350 device IO

Admin message