Commit 0daec763 authored Feb 28, 2016 by Bhaktipriya Shridhar Committed by Greg Kroah-Hartman Mar 01, 2016

staging: lustre: lnet: Use list_for_each_entry_safe



Doubly linked lists which are  iterated  using list_empty
and list_entry macros have been replaced with list_for_each_entry_safe macro.
This makes the iteration simpler and more readable.

This patch replaces the while loop containing list_empty and list_entry
with list_for_each_entry_safe.

This was done with Coccinelle.

@@
expression E1;
identifier I1, I2;
type T;
iterator name list_for_each_entry_safe;
@@

T *I1;
+ T *tmp;
...
- while (list_empty(&E1) == 0)
+ list_for_each_entry_safe (I1, tmp, &E1, I2)
{
...when != T *I1;
- I1 = list_entry(E1.next, T, I2);
...
}

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 29b2dedf

drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -2354,13 +2354,12 @@ static inline void
		ksocknal_flush_stale_txs(ksock_peer_t *peer)
		{
		ksock_tx_t *tx;
		ksock_tx_t *tmp;
		LIST_HEAD(stale_txs);

		write_lock_bh(&ksocknal_data.ksnd_global_lock);

		while (!list_empty(&peer->ksnp_tx_queue)) {
		tx = list_entry(peer->ksnp_tx_queue.next, ksock_tx_t, tx_list);

		list_for_each_entry_safe(tx, tmp, &peer->ksnp_tx_queue, tx_list) {
		if (!cfs_time_aftereq(cfs_time_current(),
		tx->tx_deadline))
		break;

Admin message