Commit 0da6d7b3 authored Aug 14, 2009 by Stephen Hemminger Committed by David S. Miller Aug 14, 2009

sky2: hold spinlock around phy_power_down

Avoid any possible problems with accessing PHY registers on shutdown.
This is a purely theoretical issue and is not related to any of the
outstanding bug reports. Since receiver and transmitter are already
shutdown and phy interrupts for this device are already disabled,
there should already be enough protection. Suggested by Mike McCormack.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 264bb4fa

drivers/net/sky2.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1893,7 +1893,9 @@ static int sky2_down(struct net_device *dev)
		synchronize_irq(hw->pdev->irq);
		napi_synchronize(&hw->napi);

		spin_lock_bh(&sky2->phy_lock);
		sky2_phy_power_down(hw, port);
		spin_unlock_bh(&sky2->phy_lock);

		/* turn off LED's */
		sky2_write16(hw, B0_Y2LED, LED_STAT_OFF);

Admin message