Commit 0da0e227 authored by Daniel Mack's avatar Daniel Mack Committed by Haojian Zhuang
Browse files

ARM: pxa3xx: provide specific platform_devices for all ssp ports 



Currently, devices for SSP ports 1, 2 and 3 are registered as compatible
devices to pxa27x-ssp. While the actual IP core is comparable, there are
some subtle differences which users of the SSP ports address by looking at
the 'type' field.

By registering devices of type 'pxa27x-ssp', this 'type' field is
incorrectly set to PXA27x_SSP which confuses the users.

To fix this, provide specific ssp port plaform devices which use
'pxa3xx-ssp' as driver name, an instantiate them from pxa3xx.c.

Signed-off-by: default avatarDaniel Mack <zonque@gmail.com>
Signed-off-by: default avatarHaojian Zhuang <haojian.zhuang@linaro.org>
parent 6f0243a1

arch/arm/mach-pxa/devices.c

+40 −2
Original line number Diff line number Diff line
@@ -1071,9 +1071,47 @@ static struct resource pxa3xx_resource_ssp4[] = { 
	},

};



/*

 * PXA3xx SSP is basically equivalent to PXA27x.

 * However, we need to register the device by the correct name in order to

 * make the driver set the correct internal type, hence we provide specific

 * platform_devices for each of them.

 */

struct platform_device pxa3xx_device_ssp1 = {

	.name		= "pxa3xx-ssp",

	.id		= 0,

	.dev		= {

		.dma_mask = &pxa27x_ssp1_dma_mask,

		.coherent_dma_mask = DMA_BIT_MASK(32),

	},

	.resource	= pxa27x_resource_ssp1,

	.num_resources	= ARRAY_SIZE(pxa27x_resource_ssp1),

};



struct platform_device pxa3xx_device_ssp2 = {

	.name		= "pxa3xx-ssp",

	.id		= 1,

	.dev		= {

		.dma_mask = &pxa27x_ssp2_dma_mask,

		.coherent_dma_mask = DMA_BIT_MASK(32),

	},

	.resource	= pxa27x_resource_ssp2,

	.num_resources	= ARRAY_SIZE(pxa27x_resource_ssp2),

};



struct platform_device pxa3xx_device_ssp3 = {

	.name		= "pxa3xx-ssp",

	.id		= 2,

	.dev		= {

		.dma_mask = &pxa27x_ssp3_dma_mask,

		.coherent_dma_mask = DMA_BIT_MASK(32),

	},

	.resource	= pxa27x_resource_ssp3,

	.num_resources	= ARRAY_SIZE(pxa27x_resource_ssp3),

};



struct platform_device pxa3xx_device_ssp4 = {

	/* PXA3xx SSP is basically equivalent to PXA27x */

	.name		= "pxa27x-ssp",

	.name		= "pxa3xx-ssp",

	.id		= 3,

	.dev		= {

		.dma_mask = &pxa3xx_ssp4_dma_mask,

arch/arm/mach-pxa/devices.h

+3 −0
Original line number Diff line number Diff line
@@ -27,6 +27,9 @@ extern struct platform_device pxa25x_device_assp; 
extern struct platform_device pxa27x_device_ssp1;

extern struct platform_device pxa27x_device_ssp2;

extern struct platform_device pxa27x_device_ssp3;

extern struct platform_device pxa3xx_device_ssp1;

extern struct platform_device pxa3xx_device_ssp2;

extern struct platform_device pxa3xx_device_ssp3;

extern struct platform_device pxa3xx_device_ssp4;



extern struct platform_device pxa25x_device_pwm0;

arch/arm/mach-pxa/pxa3xx.c

+7 −7
Original line number Diff line number Diff line
@@ -84,10 +84,10 @@ static struct clk_lookup pxa3xx_clkregs[] = { 
	INIT_CLKREG(&clk_pxa3xx_usbh, "pxa27x-ohci", NULL),

	INIT_CLKREG(&clk_pxa3xx_u2d, "pxa3xx-u2d", NULL),

	INIT_CLKREG(&clk_pxa3xx_keypad, "pxa27x-keypad", NULL),

	INIT_CLKREG(&clk_pxa3xx_ssp1, "pxa27x-ssp.0", NULL),

	INIT_CLKREG(&clk_pxa3xx_ssp2, "pxa27x-ssp.1", NULL),

	INIT_CLKREG(&clk_pxa3xx_ssp3, "pxa27x-ssp.2", NULL),

	INIT_CLKREG(&clk_pxa3xx_ssp4, "pxa27x-ssp.3", NULL),

	INIT_CLKREG(&clk_pxa3xx_ssp1, "pxa3xx-ssp.0", NULL),

	INIT_CLKREG(&clk_pxa3xx_ssp2, "pxa3xx-ssp.1", NULL),

	INIT_CLKREG(&clk_pxa3xx_ssp3, "pxa3xx-ssp.2", NULL),

	INIT_CLKREG(&clk_pxa3xx_ssp4, "pxa3xx-ssp.3", NULL),

	INIT_CLKREG(&clk_pxa3xx_pwm0, "pxa27x-pwm.0", NULL),

	INIT_CLKREG(&clk_pxa3xx_pwm1, "pxa27x-pwm.1", NULL),

	INIT_CLKREG(&clk_pxa3xx_mmc1, "pxa2xx-mci.0", NULL),
@@ -452,9 +452,9 @@ static struct platform_device *devices[] __initdata = { 
	&pxa_device_asoc_platform,

	&sa1100_device_rtc,

	&pxa_device_rtc,

	&pxa27x_device_ssp1,

	&pxa27x_device_ssp2,

	&pxa27x_device_ssp3,

	&pxa3xx_device_ssp1,

	&pxa3xx_device_ssp2,

	&pxa3xx_device_ssp3,

	&pxa3xx_device_ssp4,

	&pxa27x_device_pwm0,

	&pxa27x_device_pwm1,

CRA Git | Maintained and supported by SUSTech CRA and CCSE