Commit 0d954eeb authored Nov 28, 2017 by Quentin Monnet Committed by Daniel Borkmann Nov 30, 2017

tools: bpftool: remove spurious line break from error message



The end-of-line character inside the string would break JSON compliance.
Remove it, `p_err()` already adds a '\n' character for plain output
anyway.

Fixes: 9a5ab8bf ("tools: bpftool: turn err() and info() macros into functions")
Reported-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: Quentin Monnet <quentin.monnet@netronome.com>
Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>

parent 146882a3

tools/bpf/bpftool/main.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -51,7 +51,7 @@

		#define NEXT_ARG() ({ argc--; argv++; if (argc < 0) usage(); })
		#define NEXT_ARGP() ({ (argc)--; (argv)++; if (*argc < 0) usage(); })
		#define BAD_ARG() ({ p_err("what is '%s'?\n", *argv); -1; })
		#define BAD_ARG() ({ p_err("what is '%s'?", *argv); -1; })

		#define ERR_MAX_LEN 1024

Admin message