[DECNET] ROUTE: fix rcu_dereference() uses in /proc/net/decnet_cache (0d89d794) · Commits · 戴 / test

In dn_rt_cache_get_next(), no need to guard seq->private by a rcu_dereference() since seq is private to the thread running this function. Reading seq.private once (as guaranted bu rcu_dereference()) or several time if compiler really is dumb enough wont change the result. But we miss real spots where rcu_dereference() are needed, both in dn_rt_cache_get_first() and dn_rt_cache_get_next() Signed-off-by:

Eric Dumazet <dada1@cosmosbay.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

net/decnet/dn_route.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -1665,12 +1665,12 @@ static struct dn_route dn_rt_cache_get_first(struct seq_file seq)
		break;
		rcu_read_unlock_bh();
		}
		return rt;
		return rcu_dereference(rt);
		}

		static struct dn_route dn_rt_cache_get_next(struct seq_file seq, struct dn_route *rt)
		{
		struct dn_rt_cache_iter_state *s = rcu_dereference(seq->private);
		struct dn_rt_cache_iter_state *s = seq->private;

		rt = rt->u.dst.dn_next;
		while(!rt) {
		@@ -1680,7 +1680,7 @@ static struct dn_route dn_rt_cache_get_next(struct seq_file seq, struct dn_rou
		rcu_read_lock_bh();
		rt = dn_rt_hash_table[s->bucket].chain;
		}
		return rt;
		return rcu_dereference(rt);
		}

		static void dn_rt_cache_seq_start(struct seq_file seq, loff_t *pos)

Admin message