Commit 0d818c28 authored by David S. Miller's avatar David S. Miller
Browse files

Merge tag 'rxrpc-rewrite-20161004' of... 

Merge tag 'rxrpc-rewrite-20161004' of git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs



David Howells says:

====================
rxrpc: Fixes

This set of patches contains a bunch of fixes:

 (1) Fix an oops on incoming call to a local endpoint without a bound
     service.

 (2) Only ping for a lost reply in a client call (this is inapplicable to
     service calls).

 (3) Fix maybe uninitialised variable warnings in the ACK/ABORT sending
     function by splitting it.

 (4) Fix loss of PING RESPONSE ACKs due to them being subsumed by PING ACK
     generation.

 (5) OpenAFS improperly terminates calls it makes as a client under some
     circumstances by not fully hard-ACK'ing the last DATA packets.  This
     is alleviated by a new call appearing on the same channel implicitly
     completing the previous call on that channel.  Handle this implicit
     completion.

 (6) Properly handle expiry of service calls due to the aforementioned
     improper termination with no follow up call to implicitly complete it:

     (a) The call's background processor needs to be queued to complete the
     	 call, send an abort and notify the socket.

     (b) The call's background processor needs to notify the socket (or the
     	 kernel service) when it has completed the call.

     (c) A negative error code must thence be returned to the kernel
     	 service so that it knows the call died.

     (d) The AFS filesystem must detect the fatal error and end the call.

 (7) Must produce a DELAY ACK when the actual service operation takes a
     while to process and must cancel the ACK when the reply is ready.

 (8) Don't request an ACK on the last DATA packet of the Tx phase as this
     confuses OpenAFS.
====================

Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parents 4af1474e bf7d620a

fs/afs/rxrpc.c

+1 −1
Original line number Diff line number Diff line
@@ -418,7 +418,7 @@ static void afs_deliver_to_call(struct afs_call *call) 
						     &call->abort_code);

			if (ret == -EINPROGRESS || ret == -EAGAIN)

				return;

			if (ret == 1) {

			if (ret == 1 || ret < 0) {

				call->state = AFS_CALL_COMPLETE;

				goto done;

			}

net/rxrpc/af_rxrpc.c

+2 −2
Original line number Diff line number Diff line
@@ -678,9 +678,9 @@ static int rxrpc_release_sock(struct sock *sk) 
	sk->sk_state = RXRPC_CLOSE;

	spin_unlock_bh(&sk->sk_receive_queue.lock);



	if (rx->local && rx->local->service == rx) {

	if (rx->local && rcu_access_pointer(rx->local->service) == rx) {

		write_lock(&rx->local->services_lock);

		rx->local->service = NULL;

		rcu_assign_pointer(rx->local->service, NULL);

		write_unlock(&rx->local->services_lock);

	}

net/rxrpc/ar-internal.h

+14 −4
Original line number Diff line number Diff line
@@ -398,6 +398,7 @@ enum rxrpc_call_flag { 
	RXRPC_CALL_EXPOSED,		/* The call was exposed to the world */

	RXRPC_CALL_RX_LAST,		/* Received the last packet (at rxtx_top) */

	RXRPC_CALL_TX_LAST,		/* Last packet in Tx buffer (at rxtx_top) */

	RXRPC_CALL_SEND_PING,		/* A ping will need to be sent */

	RXRPC_CALL_PINGING,		/* Ping in process */

	RXRPC_CALL_RETRANS_TIMEOUT,	/* Retransmission due to timeout occurred */

};
@@ -410,6 +411,7 @@ enum rxrpc_call_event { 
	RXRPC_CALL_EV_ABORT,		/* need to generate abort */

	RXRPC_CALL_EV_TIMER,		/* Timer expired */

	RXRPC_CALL_EV_RESEND,		/* Tx resend required */

	RXRPC_CALL_EV_PING,		/* Ping send required */

};



/*
@@ -466,6 +468,7 @@ struct rxrpc_call { 
	struct rxrpc_sock __rcu	*socket;	/* socket responsible */

	ktime_t			ack_at;		/* When deferred ACK needs to happen */

	ktime_t			resend_at;	/* When next resend needs to happen */

	ktime_t			ping_at;	/* When next to send a ping */

	ktime_t			expire_at;	/* When the call times out */

	struct timer_list	timer;		/* Combined event timer */

	struct work_struct	processor;	/* Event processor */
@@ -558,8 +561,10 @@ struct rxrpc_call { 
	rxrpc_seq_t		ackr_prev_seq;	/* previous sequence number received */

	rxrpc_seq_t		ackr_consumed;	/* Highest packet shown consumed */

	rxrpc_seq_t		ackr_seen;	/* Highest packet shown seen */

	rxrpc_serial_t		ackr_ping;	/* Last ping sent */

	ktime_t			ackr_ping_time;	/* Time last ping sent */



	/* ping management */

	rxrpc_serial_t		ping_serial;	/* Last ping sent */

	ktime_t			ping_time;	/* Time last ping sent */



	/* transmission-phase ACK management */

	ktime_t			acks_latest_ts;	/* Timestamp of latest ACK received */
@@ -728,8 +733,10 @@ extern const char rxrpc_rtt_rx_traces[rxrpc_rtt_rx__nr_trace][5]; 
enum rxrpc_timer_trace {

	rxrpc_timer_begin,

	rxrpc_timer_init_for_reply,

	rxrpc_timer_init_for_send_reply,

	rxrpc_timer_expired,

	rxrpc_timer_set_for_ack,

	rxrpc_timer_set_for_ping,

	rxrpc_timer_set_for_resend,

	rxrpc_timer_set_for_send,

	rxrpc_timer__nr_trace
@@ -743,6 +750,7 @@ enum rxrpc_propose_ack_trace { 
	rxrpc_propose_ack_ping_for_lost_ack,

	rxrpc_propose_ack_ping_for_lost_reply,

	rxrpc_propose_ack_ping_for_params,

	rxrpc_propose_ack_processing_op,

	rxrpc_propose_ack_respond_to_ack,

	rxrpc_propose_ack_respond_to_ping,

	rxrpc_propose_ack_retry_tx,
@@ -777,7 +785,7 @@ extern const char rxrpc_congest_modes[NR__RXRPC_CONGEST_MODES][10]; 
extern const char rxrpc_congest_changes[rxrpc_congest__nr_change][9];



extern const char *const rxrpc_pkts[];

extern const char const rxrpc_ack_names[RXRPC_ACK__INVALID + 1][4];

extern const char rxrpc_ack_names[RXRPC_ACK__INVALID + 1][4];



#include <trace/events/rxrpc.h>
@@ -805,6 +813,7 @@ int rxrpc_reject_call(struct rxrpc_sock *); 
/*

 * call_event.c

 */

void __rxrpc_set_timer(struct rxrpc_call *, enum rxrpc_timer_trace, ktime_t);

void rxrpc_set_timer(struct rxrpc_call *, enum rxrpc_timer_trace, ktime_t);

void rxrpc_propose_ACK(struct rxrpc_call *, u8, u16, u32, bool, bool,

		       enum rxrpc_propose_ack_trace);
@@ -1068,7 +1077,8 @@ extern const s8 rxrpc_ack_priority[]; 
/*

 * output.c

 */

int rxrpc_send_call_packet(struct rxrpc_call *, u8);

int rxrpc_send_ack_packet(struct rxrpc_call *, bool);

int rxrpc_send_abort_packet(struct rxrpc_call *);

int rxrpc_send_data_packet(struct rxrpc_call *, struct sk_buff *, bool);

void rxrpc_reject_packets(struct rxrpc_local *);

net/rxrpc/call_accept.c

+2 −2
Original line number Diff line number Diff line
@@ -337,7 +337,7 @@ struct rxrpc_call *rxrpc_new_incoming_call(struct rxrpc_local *local, 


	/* Get the socket providing the service */

	rx = rcu_dereference(local->service);

	if (service_id == rx->srx.srx_service)

	if (rx && service_id == rx->srx.srx_service)

		goto found_service;



	trace_rxrpc_abort("INV", sp->hdr.cid, sp->hdr.callNumber, sp->hdr.seq,
@@ -565,7 +565,7 @@ out_discard: 
	write_unlock_bh(&call->state_lock);

	write_unlock(&rx->call_lock);

	if (abort) {

		rxrpc_send_call_packet(call, RXRPC_PACKET_TYPE_ABORT);

		rxrpc_send_abort_packet(call);

		rxrpc_release_call(rx, call);

		rxrpc_put_call(call, rxrpc_call_put);

	}

net/rxrpc/call_event.c

+64 −13
Original line number Diff line number Diff line
@@ -24,19 +24,20 @@ 
/*

 * Set the timer

 */

void rxrpc_set_timer(struct rxrpc_call *call, enum rxrpc_timer_trace why,

void __rxrpc_set_timer(struct rxrpc_call *call, enum rxrpc_timer_trace why,

		       ktime_t now)

{

	unsigned long t_j, now_j = jiffies;

	ktime_t t;

	bool queue = false;



	read_lock_bh(&call->state_lock);



	if (call->state < RXRPC_CALL_COMPLETE) {

		t = call->expire_at;

		if (!ktime_after(t, now))

		if (!ktime_after(t, now)) {

			trace_rxrpc_timer(call, why, now, now_j);

			queue = true;

			goto out;

		}



		if (!ktime_after(call->resend_at, now)) {

			call->resend_at = call->expire_at;
@@ -54,6 +55,14 @@ void rxrpc_set_timer(struct rxrpc_call *call, enum rxrpc_timer_trace why, 
			t = call->ack_at;

		}



		if (!ktime_after(call->ping_at, now)) {

			call->ping_at = call->expire_at;

			if (!test_and_set_bit(RXRPC_CALL_EV_PING, &call->events))

				queue = true;

		} else if (ktime_before(call->ping_at, t)) {

			t = call->ping_at;

		}



		t_j = nsecs_to_jiffies(ktime_to_ns(ktime_sub(t, now)));

		t_j += jiffies;
@@ -68,15 +77,45 @@ void rxrpc_set_timer(struct rxrpc_call *call, enum rxrpc_timer_trace why, 
			mod_timer(&call->timer, t_j);

			trace_rxrpc_timer(call, why, now, now_j);

		}

	}



out:

	if (queue)

		rxrpc_queue_call(call);

}



out:

/*

 * Set the timer

 */

void rxrpc_set_timer(struct rxrpc_call *call, enum rxrpc_timer_trace why,

		     ktime_t now)

{

	read_lock_bh(&call->state_lock);

	__rxrpc_set_timer(call, why, now);

	read_unlock_bh(&call->state_lock);

}



/*

 * Propose a PING ACK be sent.

 */

static void rxrpc_propose_ping(struct rxrpc_call *call,

			       bool immediate, bool background)

{

	if (immediate) {

		if (background &&

		    !test_and_set_bit(RXRPC_CALL_EV_PING, &call->events))

			rxrpc_queue_call(call);

	} else {

		ktime_t now = ktime_get_real();

		ktime_t ping_at = ktime_add_ms(now, rxrpc_idle_ack_delay);



		if (ktime_before(ping_at, call->ping_at)) {

			call->ping_at = ping_at;

			rxrpc_set_timer(call, rxrpc_timer_set_for_ping, now);

		}

	}

}



/*

 * propose an ACK be sent

 */
@@ -90,6 +129,14 @@ static void __rxrpc_propose_ACK(struct rxrpc_call *call, u8 ack_reason, 
	ktime_t now, ack_at;

	s8 prior = rxrpc_ack_priority[ack_reason];



	/* Pings are handled specially because we don't want to accidentally

	 * lose a ping response by subsuming it into a ping.

	 */

	if (ack_reason == RXRPC_ACK_PING) {

		rxrpc_propose_ping(call, immediate, background);

		goto trace;

	}



	/* Update DELAY, IDLE, REQUESTED and PING_RESPONSE ACK serial

	 * numbers, but we don't alter the timeout.

	 */
@@ -125,7 +172,6 @@ static void __rxrpc_propose_ACK(struct rxrpc_call *call, u8 ack_reason, 
			expiry = rxrpc_soft_ack_delay;

		break;



	case RXRPC_ACK_PING:

	case RXRPC_ACK_IDLE:

		if (rxrpc_idle_ack_delay < expiry)

			expiry = rxrpc_idle_ack_delay;
@@ -253,7 +299,7 @@ static void rxrpc_resend(struct rxrpc_call *call, ktime_t now) 
			goto out;

		rxrpc_propose_ACK(call, RXRPC_ACK_PING, 0, 0, true, false,

				  rxrpc_propose_ack_ping_for_lost_ack);

		rxrpc_send_call_packet(call, RXRPC_PACKET_TYPE_ACK);

		rxrpc_send_ack_packet(call, true);

		goto out;

	}
@@ -328,12 +374,13 @@ void rxrpc_process_call(struct work_struct *work) 


recheck_state:

	if (test_and_clear_bit(RXRPC_CALL_EV_ABORT, &call->events)) {

		rxrpc_send_call_packet(call, RXRPC_PACKET_TYPE_ABORT);

		rxrpc_send_abort_packet(call);

		goto recheck_state;

	}



	if (call->state == RXRPC_CALL_COMPLETE) {

		del_timer_sync(&call->timer);

		rxrpc_notify_socket(call);

		goto out_put;

	}
@@ -345,13 +392,17 @@ recheck_state: 
	}



	if (test_and_clear_bit(RXRPC_CALL_EV_ACK, &call->events)) {

		call->ack_at = call->expire_at;

		if (call->ackr_reason) {

			rxrpc_send_call_packet(call, RXRPC_PACKET_TYPE_ACK);

			rxrpc_send_ack_packet(call, false);

			goto recheck_state;

		}

	}



	if (test_and_clear_bit(RXRPC_CALL_EV_PING, &call->events)) {

		rxrpc_send_ack_packet(call, true);

		goto recheck_state;

	}



	if (test_and_clear_bit(RXRPC_CALL_EV_RESEND, &call->events)) {

		rxrpc_resend(call, now);

		goto recheck_state;

CRA Git | Maintained and supported by SUSTech CRA and CCSE