Commit 0d813d99 authored by Wolfram Sang's avatar Wolfram Sang Committed by Ben Dooks
Browse files

i2c-pxa: only define 'blue_murder'-function if DEBUG is #defined 



This talkative function is also called on timeouts. As timeouts can
happen on regular writes to EEPROMs (no error case), this creates false
positives.  Giving lots of details is interesting only for developers
anyhow, so just use the function if DEBUG is #defined.

Signed-off-by: default avatarWolfram Sang <w.sang@pengutronix.de>
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Cc: Russell King <rmk+kernel@arm.linux.org.uk>
Acked-by: default avatarEric Miao <eric.y.miao@gmail.com>
Cc: Roel Kluin <roel.kluin@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>
parent 29412e69

drivers/i2c/busses/i2c-pxa.c

+14 −10
Original line number Diff line number Diff line
@@ -209,16 +209,6 @@ static void i2c_pxa_show_state(struct pxa_i2c *i2c, int lno, const char *fname) 
}



#define show_state(i2c) i2c_pxa_show_state(i2c, __LINE__, __func__)

#else

#define i2c_debug	0



#define show_state(i2c) do { } while (0)

#define decode_ISR(val) do { } while (0)

#define decode_ICR(val) do { } while (0)

#endif



static void i2c_pxa_master_complete(struct pxa_i2c *i2c, int ret);

static irqreturn_t i2c_pxa_handler(int this_irq, void *dev_id);



static void i2c_pxa_scream_blue_murder(struct pxa_i2c *i2c, const char *why)

{
@@ -234,6 +224,20 @@ static void i2c_pxa_scream_blue_murder(struct pxa_i2c *i2c, const char *why) 
	printk("\n");

}



#else /* ifdef DEBUG */



#define i2c_debug	0



#define show_state(i2c) do { } while (0)

#define decode_ISR(val) do { } while (0)

#define decode_ICR(val) do { } while (0)

#define i2c_pxa_scream_blue_murder(i2c, why) do { } while (0)



#endif /* ifdef DEBUG / else */



static void i2c_pxa_master_complete(struct pxa_i2c *i2c, int ret);

static irqreturn_t i2c_pxa_handler(int this_irq, void *dev_id);



static inline int i2c_pxa_is_slavemode(struct pxa_i2c *i2c)

{

	return !(readl(_ICR(i2c)) & ICR_SCLE);

CRA Git | Maintained and supported by SUSTech CRA and CCSE