Commit 0d7718f6 authored Oct 10, 2016 by Nikolay Borisov Committed by Ilya Dryomov Oct 15, 2016

ceph: fix error handling in ceph_read_iter



In case __ceph_do_getattr returns an error and the retry_op in
ceph_read_iter is not READ_INLINE, then it's possible to invoke
__free_page on a page which is NULL, this naturally leads to a crash.
This can happen when, for example, a process waiting on a MDS reply
receives sigterm.

Fix this by explicitly checking whether the page is set or not.

Cc: stable@vger.kernel.org # 3.19+
Signed-off-by: Nikolay Borisov <kernel@kyup.com>
Reviewed-by: Yan, Zheng <zyan@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

parent 4d73644b

fs/ceph/file.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1272,6 +1272,7 @@ again:
		statret = __ceph_do_getattr(inode, page,
		CEPH_STAT_CAP_INLINE_DATA, !!page);
		if (statret < 0) {
		if (page)
		__free_page(page);
		if (statret == -ENODATA) {
		BUG_ON(retry_op != READ_INLINE);

Admin message