Commit 0d5c6e1c authored by Steven Rostedt's avatar Steven Rostedt Committed by Steven Rostedt
Browse files

tracing: Use irq_work for wake ups and remove *_nowake_*() functions 



Have the ring buffer commit function use the irq_work infrastructure to
wake up any waiters waiting on the ring buffer for new data. The irq_work
was created for such a purpose, where doing the actual wake up at the
time of adding data is too dangerous, as an event or function trace may
be in the midst of the work queue locks and cause deadlocks. The irq_work
will either delay the action to the next timer interrupt, or trigger an IPI
to itself forcing an interrupt to do the work (in a safe location).

With irq_work, all ring buffer commits can safely do wakeups, removing
the need for the ring buffer commit "nowake" variants, which were used
by events and function tracing. All commits can now safely use the
normal commit, and the "nowake" variants can be removed.

Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: default avatarSteven Rostedt <rostedt@goodmis.org>
parent 02404baf

include/linux/ftrace_event.h

+7 −7
Original line number Diff line number Diff line
@@ -127,10 +127,10 @@ trace_current_buffer_lock_reserve(struct ring_buffer **current_buffer, 
void trace_current_buffer_unlock_commit(struct ring_buffer *buffer,

					struct ring_buffer_event *event,

					unsigned long flags, int pc);

void trace_nowake_buffer_unlock_commit(struct ring_buffer *buffer,

void trace_buffer_unlock_commit(struct ring_buffer *buffer,

				struct ring_buffer_event *event,

				unsigned long flags, int pc);

void trace_nowake_buffer_unlock_commit_regs(struct ring_buffer *buffer,

void trace_buffer_unlock_commit_regs(struct ring_buffer *buffer,

				     struct ring_buffer_event *event,

				     unsigned long flags, int pc,

				     struct pt_regs *regs);

include/trace/ftrace.h

+1 −2
Original line number Diff line number Diff line
@@ -545,8 +545,7 @@ ftrace_raw_event_##call(void *__data, proto) \ 
	{ assign; }							\

									\

	if (!filter_current_check_discard(buffer, event_call, entry, event)) \

		trace_nowake_buffer_unlock_commit(buffer,		\

						  event, irq_flags, pc); \

		trace_buffer_unlock_commit(buffer, event, irq_flags, pc); \

}

/*

 * The ftrace_test_probe is compiled out, it is only here as a build time check

kernel/trace/Kconfig

+1 −0
Original line number Diff line number Diff line
@@ -119,6 +119,7 @@ config TRACING 
	select BINARY_PRINTF

	select EVENT_TRACING

	select TRACE_CLOCK

	select IRQ_WORK



config GENERIC_TRACER

	bool

kernel/trace/trace.c

+68 −53
Original line number Diff line number Diff line
@@ -19,6 +19,7 @@ 
#include <linux/seq_file.h>

#include <linux/notifier.h>

#include <linux/irqflags.h>

#include <linux/irq_work.h>

#include <linux/debugfs.h>

#include <linux/pagemap.h>

#include <linux/hardirq.h>
@@ -84,6 +85,14 @@ static int dummy_set_flag(u32 old_flags, u32 bit, int set) 
 */

static DEFINE_PER_CPU(bool, trace_cmdline_save);



/*

 * When a reader is waiting for data, then this variable is

 * set to true.

 */

static bool trace_wakeup_needed;



static struct irq_work trace_work_wakeup;



/*

 * Kill all tracing for good (never come back).

 * It is initialized to 1 but will turn to zero if the initialization
@@ -329,12 +338,18 @@ unsigned long trace_flags = TRACE_ITER_PRINT_PARENT | TRACE_ITER_PRINTK | 
static int trace_stop_count;

static DEFINE_RAW_SPINLOCK(tracing_start_lock);



static void wakeup_work_handler(struct work_struct *work)

/**

 * trace_wake_up - wake up tasks waiting for trace input

 *

 * Schedules a delayed work to wake up any task that is blocked on the

 * trace_wait queue. These is used with trace_poll for tasks polling the

 * trace.

 */

static void trace_wake_up(struct irq_work *work)

{

	wake_up(&trace_wait);

}

	wake_up_all(&trace_wait);



static DECLARE_DELAYED_WORK(wakeup_work, wakeup_work_handler);

}



/**

 * tracing_on - enable tracing buffers
@@ -389,22 +404,6 @@ int tracing_is_on(void) 
}

EXPORT_SYMBOL_GPL(tracing_is_on);



/**

 * trace_wake_up - wake up tasks waiting for trace input

 *

 * Schedules a delayed work to wake up any task that is blocked on the

 * trace_wait queue. These is used with trace_poll for tasks polling the

 * trace.

 */

void trace_wake_up(void)

{

	const unsigned long delay = msecs_to_jiffies(2);



	if (trace_flags & TRACE_ITER_BLOCK)

		return;

	schedule_delayed_work(&wakeup_work, delay);

}



static int __init set_buf_size(char *str)

{

	unsigned long buf_size;
@@ -753,6 +752,40 @@ update_max_tr_single(struct trace_array *tr, struct task_struct *tsk, int cpu) 
}

#endif /* CONFIG_TRACER_MAX_TRACE */



static void default_wait_pipe(struct trace_iterator *iter)

{

	DEFINE_WAIT(wait);



	prepare_to_wait(&trace_wait, &wait, TASK_INTERRUPTIBLE);



	/*

	 * The events can happen in critical sections where

	 * checking a work queue can cause deadlocks.

	 * After adding a task to the queue, this flag is set

	 * only to notify events to try to wake up the queue

	 * using irq_work.

	 *

	 * We don't clear it even if the buffer is no longer

	 * empty. The flag only causes the next event to run

	 * irq_work to do the work queue wake up. The worse

	 * that can happen if we race with !trace_empty() is that

	 * an event will cause an irq_work to try to wake up

	 * an empty queue.

	 *

	 * There's no reason to protect this flag either, as

	 * the work queue and irq_work logic will do the necessary

	 * synchronization for the wake ups. The only thing

	 * that is necessary is that the wake up happens after

	 * a task has been queued. It's OK for spurious wake ups.

	 */

	trace_wakeup_needed = true;



	if (trace_empty(iter))

		schedule();



	finish_wait(&trace_wait, &wait);

}



/**

 * register_tracer - register a tracer with the ftrace system.

 * @type - the plugin for the tracer
@@ -1156,30 +1189,32 @@ void 
__buffer_unlock_commit(struct ring_buffer *buffer, struct ring_buffer_event *event)

{

	__this_cpu_write(trace_cmdline_save, true);

	if (trace_wakeup_needed) {

		trace_wakeup_needed = false;

		/* irq_work_queue() supplies it's own memory barriers */

		irq_work_queue(&trace_work_wakeup);

	}

	ring_buffer_unlock_commit(buffer, event);

}



static inline void

__trace_buffer_unlock_commit(struct ring_buffer *buffer,

			     struct ring_buffer_event *event,

			     unsigned long flags, int pc,

			     int wake)

			     unsigned long flags, int pc)

{

	__buffer_unlock_commit(buffer, event);



	ftrace_trace_stack(buffer, flags, 6, pc);

	ftrace_trace_userstack(buffer, flags, pc);



	if (wake)

		trace_wake_up();

}



void trace_buffer_unlock_commit(struct ring_buffer *buffer,

				struct ring_buffer_event *event,

				unsigned long flags, int pc)

{

	__trace_buffer_unlock_commit(buffer, event, flags, pc, 1);

	__trace_buffer_unlock_commit(buffer, event, flags, pc);

}

EXPORT_SYMBOL_GPL(trace_buffer_unlock_commit);



struct ring_buffer_event *

trace_current_buffer_lock_reserve(struct ring_buffer **current_rb,
@@ -1196,19 +1231,11 @@ void trace_current_buffer_unlock_commit(struct ring_buffer *buffer, 
					struct ring_buffer_event *event,

					unsigned long flags, int pc)

{

	__trace_buffer_unlock_commit(buffer, event, flags, pc, 1);

	__trace_buffer_unlock_commit(buffer, event, flags, pc);

}

EXPORT_SYMBOL_GPL(trace_current_buffer_unlock_commit);



void trace_nowake_buffer_unlock_commit(struct ring_buffer *buffer,

				       struct ring_buffer_event *event,

				       unsigned long flags, int pc)

{

	__trace_buffer_unlock_commit(buffer, event, flags, pc, 0);

}

EXPORT_SYMBOL_GPL(trace_nowake_buffer_unlock_commit);



void trace_nowake_buffer_unlock_commit_regs(struct ring_buffer *buffer,

void trace_buffer_unlock_commit_regs(struct ring_buffer *buffer,

				     struct ring_buffer_event *event,

				     unsigned long flags, int pc,

				     struct pt_regs *regs)
@@ -1218,7 +1245,7 @@ void trace_nowake_buffer_unlock_commit_regs(struct ring_buffer *buffer, 
	ftrace_trace_stack_regs(buffer, flags, 0, pc, regs);

	ftrace_trace_userstack(buffer, flags, pc);

}

EXPORT_SYMBOL_GPL(trace_nowake_buffer_unlock_commit_regs);

EXPORT_SYMBOL_GPL(trace_buffer_unlock_commit_regs);



void trace_current_buffer_discard_commit(struct ring_buffer *buffer,

					 struct ring_buffer_event *event)
@@ -3354,19 +3381,6 @@ tracing_poll_pipe(struct file *filp, poll_table *poll_table) 
	}

}





void default_wait_pipe(struct trace_iterator *iter)

{

	DEFINE_WAIT(wait);



	prepare_to_wait(&trace_wait, &wait, TASK_INTERRUPTIBLE);



	if (trace_empty(iter))

		schedule();



	finish_wait(&trace_wait, &wait);

}



/*

 * This is a make-shift waitqueue.

 * A tracer might use this callback on some rare cases:
@@ -5107,6 +5121,7 @@ __init static int tracer_alloc_buffers(void) 
#endif



	trace_init_cmdlines();

	init_irq_work(&trace_work_wakeup, trace_wake_up);



	register_tracer(&nop_trace);

	current_trace = &nop_trace;

kernel/trace/trace.h

+0 −5
Original line number Diff line number Diff line
@@ -327,7 +327,6 @@ trace_buffer_iter(struct trace_iterator *iter, int cpu) 


int tracer_init(struct tracer *t, struct trace_array *tr);

int tracing_is_enabled(void);

void trace_wake_up(void);

void tracing_reset(struct trace_array *tr, int cpu);

void tracing_reset_online_cpus(struct trace_array *tr);

void tracing_reset_current(int cpu);
@@ -349,9 +348,6 @@ trace_buffer_lock_reserve(struct ring_buffer *buffer, 
			  unsigned long len,

			  unsigned long flags,

			  int pc);

void trace_buffer_unlock_commit(struct ring_buffer *buffer,

				struct ring_buffer_event *event,

				unsigned long flags, int pc);



struct trace_entry *tracing_get_trace_entry(struct trace_array *tr,

						struct trace_array_cpu *data);
@@ -370,7 +366,6 @@ void trace_init_global_iter(struct trace_iterator *iter); 


void tracing_iter_reset(struct trace_iterator *iter, int cpu);



void default_wait_pipe(struct trace_iterator *iter);

void poll_wait_pipe(struct trace_iterator *iter);



void ftrace(struct trace_array *tr,

CRA Git | Maintained and supported by SUSTech CRA and CCSE