Commit 0d360d64 authored Aug 06, 2020 by Stanislav Fomichev Committed by Alexei Starovoitov Aug 06, 2020

bpf: Remove inline from bpf_do_trace_printk



I get the following error during compilation on my side:
kernel/trace/bpf_trace.c: In function 'bpf_do_trace_printk':
kernel/trace/bpf_trace.c:386:34: error: function 'bpf_do_trace_printk' can never be inlined because it uses variable argument lists
 static inline __printf(1, 0) int bpf_do_trace_printk(const char *fmt, ...)
                                  ^

Fixes: ac5a72ea ("bpf: Use dedicated bpf_trace_printk event instead of trace_printk()")
Signed-off-by: Stanislav Fomichev <sdf@google.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Link: https://lore.kernel.org/bpf/20200806182612.1390883-1-sdf@google.com

parent d48556f4

kernel/trace/bpf_trace.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -383,7 +383,7 @@ static DEFINE_RAW_SPINLOCK(trace_printk_lock);

		#define BPF_TRACE_PRINTK_SIZE 1024

		static inline __printf(1, 0) int bpf_do_trace_printk(const char *fmt, ...)
		static __printf(1, 0) int bpf_do_trace_printk(const char *fmt, ...)
		{
		static char buf[BPF_TRACE_PRINTK_SIZE];
		unsigned long flags;

Admin message