Commit 0d352a3a authored Sep 16, 2019 by Iago Toral Quiroga Committed by Eric Anholt Sep 18, 2019

drm/v3d: don't leak bin job if v3d_job_init fails.



If the initialization of the job fails we need to kfree() it
before returning.

Signed-off-by: Iago Toral Quiroga <itoral@igalia.com>
Signed-off-by: Eric Anholt <eric@anholt.net>
Link: https://patchwork.freedesktop.org/patch/msgid/20190916071125.5255-1-itoral@igalia.com


Fixes: a783a09e ("drm/v3d: Refactor job management.")
Reviewed-by: Eric Anholt <eric@anholt.net>

parent 69b22f51

drivers/gpu/drm/v3d/v3d_gem.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -563,6 +563,7 @@ v3d_submit_cl_ioctl(struct drm_device dev, void data,
		ret = v3d_job_init(v3d, file_priv, &bin->base,
		v3d_job_free, args->in_sync_bcl);
		if (ret) {
		kfree(bin);
		v3d_job_put(&render->base);
		return ret;
		}

Admin message